[Laszlo-reviews] For Review: Change 20100611-maxcarlson-e Summary: UPDATED: Fix text mouse interaction in swf10

[Maynard Demmon]

Approved.

Max Carlson wrote:
> Change 20100611-maxcarlson-e by maxcarlson at Friendly.local on 2010-06-11 11:30:44 MDT
>     in /Users/maxcarlson/openlaszlo/trunk-clean
>     for http://svn.openlaszlo.org/openlaszlo/trunk
> 
> Summary: UPDATED: Fix text mouse interaction in swf10
> 
> Bugs Fixed: LPP-9101 - swf10: mouse events for text links interfere with clickable views beneath them
> 
> Technical Reviewer: ptw
> QA Reviewer: hminsky
> 
> Details: LzTextSprite - Set mouseEnabled from activateLinks() which is called when ontextlink is registerd in LzText, or selectable or clickable are set to true.
> 
> swf/LzSprite.as - Add textlinksneedmouseevents quirk, set to false.
> 
> dhtml/LzSprite.js - Add textlinksneedmouseevents quirk, set to false.  Misc cleanup.
> 
> swf9/LzTextSprite.as - Use 'textfield' class variable instead of various local coercions.  Move mouse event (de)registration to activateLinks().  Don't register for mouse events by default.  setClickable() and setSelectable() call updateMouseEnabled() to enable/disable mouse events.  
> 
> swf/LzSprite.as - Add textlinksneedmouseevents quirk, set to true.  Explicitly set mouseChildren to false until a child sprite is added.  Debug.write -> warn().
> 
> LzText - Add LzTextlinkEvent class and declared event.  In the constructor, use special LzTextlinkEvent declared event class to turn off/on clickable text if the textlinksneedmouseevents quirk is true.
> 
> Tests: See LPP-9101 - text and gray area now show onmouseover/out events in the debugger consistently, links in debugger still work.  Clickable area still does not match swf8, e.g. over/out events happen outside the bounds - see LPP-9051.
> 
> Files:
> M       WEB-INF/lps/lfc/kernel/swf/LzSprite.as
> M       WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
> M       WEB-INF/lps/lfc/kernel/swf9/LzTextSprite.as
> M       WEB-INF/lps/lfc/kernel/swf9/LzSprite.as
> M       WEB-INF/lps/lfc/views/LzText.lzs
> 
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20100611-maxcarlson-e.tar