[Laszlo-reviews] For Review: Change 20100624-hqm-t Summary: fix for "Image order when resource src is a folder"

[P T Withington]

You've left a System.err.println in swf9writer, otherwise, approved.

On 2010-06-25, at 00:00, Henry Minsky wrote:

> Change 20100624-hqm-t by hqm at new-host-4.home on 2010-06-24 23:35:57 EDT
>    in /Users/hqm/openlaszlo/trunk
>    for http://svn.openlaszlo.org/openlaszlo/trunk
> 
> Summary: fix for "Image order when resource src is a folder"
> 
> New Features:
> 
> Bugs Fixed: LPP-9143
> 
> Technical Reviewer: max
> QA Reviewer: ptw
> Doc Reviewer: (pending)
> 
> Documentation:
> 
> Release Notes:
> 
> Overview:
> 
> The sort order on a directory comes back in strict lexicographic order,
> which is not intuitive for people. 
> 
> This changes uses a "natural order sort" on the directory listing, so
> that files come out in the "natural" order humans expect, e.g., sorted
> numerically where possible.
> 
> So for example a directory with files named
> ["f1.png", "f10.png", "f11.png", "f2.png" ]
>     would be sorted to this order:
> ["f1.png", "f2.png" , "f10.png", "f11.png"]
> 
> Details:
> 
> + added new Comparator, NaturalOrderComparator
> 
> + made the importResouce methods of  the ObjectWriters for the runtimes sort the
> files that way
> 
> Tests:
> 
> test case in test/lfc/multiframe/frames.lzx, when clicking the 'frame'
> button, image of letter should advance in alphabetical order
> 
> 
> Files:
> A       test/lfc/multiframe
> A       test/lfc/multiframe/frames.lzx
> A       test/lfc/multiframe/resources
> A       test/lfc/multiframe/resources/f7.png
> A       test/lfc/multiframe/resources/f8.png
> A       test/lfc/multiframe/resources/f9.png
> A       test/lfc/multiframe/resources/f0.png
> A       test/lfc/multiframe/resources/f1.png
> A       test/lfc/multiframe/resources/f10.png
> A       test/lfc/multiframe/resources/f11.png
> A       test/lfc/multiframe/resources/f2.png
> A       test/lfc/multiframe/resources/f3.png
> A       test/lfc/multiframe/resources/f4.png
> A       test/lfc/multiframe/resources/f5.png
> A       test/lfc/multiframe/resources/f6.png
> A       WEB-INF/lps/server/src/org/openlaszlo/utils/NaturalOrderComparator.java
> M       WEB-INF/lps/server/src/org/openlaszlo/compiler/DHTMLWriter.java
> M       WEB-INF/lps/server/src/org/openlaszlo/compiler/SWFWriter.java
> M       WEB-INF/lps/server/src/org/openlaszlo/compiler/SWF9Writer.java
> A       credits/naturalsort.txt
> 
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20100624-hqm-t.tar