[Laszlo-reviews] For Review: Change 20100624-maxcarlson-E Summary: Add support for CSS3 transition attribute

Max Carlson max at openlaszlo.org
Thu Jun 24 14:38:07 PDT 2010


Change 20100624-maxcarlson-E by maxcarlson at friendly on 2010-06-24 13:52:05 PDT
    in /Users/maxcarlson/openlaszlo/trunk-clean
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Add support for CSS3 transition attribute

New Features: Node attributes that have corresponding transition set will be automatically animated.  See LzNode.transition for more details.

Bugs Fixed: LPP-9020 - Support CSS3 transitions

Technical Reviewer: ptw
QA Reviewer: hminsky

Release Notes: Setting the 'transition' attribute will cause subsequent calls to be animated, e.g.:

<canvas> 
    <button transition="x 2s" onclick="this.setAttribute('x', 200)">Hello Laszlo!</button>
</canvas>

Details: LzNode - Add transition propery event and setter that parses the CSS3 transition syntax.  Override LzEventable.__skipSetter() to do transition animations.  

LzEventable - Add __LZskipsetter hash to track attributes that should have their setter call skipped and __skipSetter() called instead.  

LaszloAnimation - Inline setValue() calls into update().

Tests: Animators run as before clicking this button causes it to animate:
<canvas>
    <button transition="x 2s" onclick="this.setAttribute('x', 200)">Hello
    Laszlo!</button>
</canvas>

Files:
M       WEB-INF/lps/lfc/core/LzNode.lzs
M       WEB-INF/lps/lfc/core/LzEventable.lzs
M       WEB-INF/lps/lfc/controllers/LaszloAnimation.lzs

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20100624-maxcarlson-E.tar



More information about the Laszlo-reviews mailing list