[Laszlo-reviews] For Review: Change 20100621-ptw-L Summary: Clean up <text>/pattern validator

[Max Carlson]

Approved for QA!

Regards,
Max Carlson
OpenLaszlo.org

On 6/21/10 3:21 PM, P T Withington wrote:
> Change 20100621-ptw-L by ptw at padme.home on 2010-06-21 18:12:12 EDT
>      in /Users/ptw/OpenLaszlo/trunk
>      for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: Clean up<text>/pattern validator
>
> Bugs Fixed:
>      LPP-9133 On dhtml for inputtext/pattern attribute unicode escape sequences must be done like this \\u0001 whereas on swf8/10 like this \u0001
>      LPP-9134 WARNING: LzTextSprite.setPattern argument '[^\x01-\b\v-\f\x0e-\x1f\x7f-\x84\x86-\x9f]*' must be of the form "[...]*"
>
> Technical Reviewer: andre.bargull at udo.edu (pending)
> QA Reviewer: max at openlaszlo.org (pending)
>
> Details:
>      LzTextSprite*:  Don't use RegExp to validate character set pattern
>      as /.*/ will fail to match line break characters in the pattern.
>      Just use brute force to search for the leading '[' and trailing
>      ']*'.  If you don't install the pattern, issue an error, not a
>      warning.
>
>
> Tests:
>      Test case from bug report
>
> Files:
> M       WEB-INF/lps/lfc/kernel/swf/LzTextSprite.as
> M       WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js
> M       WEB-INF/lps/lfc/kernel/dhtml/LzInputTextSprite.js
> M       WEB-INF/lps/lfc/kernel/swf9/LzTextSprite.as
>
>
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20100621-ptw-L.tar