[Laszlo-reviews] For Review: Change 20100621-maxcarlson-i Summary: Fix warnings with basecomponent tinting

Max Carlson max at openlaszlo.org
Mon Jun 21 16:36:30 PDT 2010


Change 20100621-maxcarlson-i by maxcarlson at friendly on 2010-06-21 16:31:42 PDT
    in /Users/maxcarlson/openlaszlo/trunk-clean
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Fix warnings with basecomponent tinting

Bugs Fixed: LPP-9132 - Regression: examples/animation/animation.lzx?lzr=swf8&debug=true failing to start up

Technical Reviewer: ptw
QA Reviewer: hminsky, mdemmon

Details: LzUtils - Ensure LzColorUtils.fromrgb() returns integers when no alpha component is supplied.

LaszloView - Update docs, update deprecation warning to not include 'this' which caused swf8 to fail to start up.  Updatei tintcolor setter implementation to actually tint.

basecomponent - Use LzView.tintcolor instead of setColorTransform().

Tests: examples/animation/animation.lzx runs in swf8 debug mode, runs as before in swf10 also - but without warnings.

Files:
M       WEB-INF/lps/lfc/services/LzUtils.lzs
M       WEB-INF/lps/lfc/views/LaszloView.lzs
M       lps/components/base/basecomponent.lzx

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20100621-maxcarlson-i.tar



More information about the Laszlo-reviews mailing list