[Laszlo-reviews] For Review: Change 20100604-ptw-7 Summary: Remove earlySetters kludges

[P T Withington]

Change 20100604-ptw-7 by ptw at padme.home on 2010-06-04 08:47:02 EDT
    in /Users/ptw/OpenLaszlo/trunk
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Remove earlySetters kludges

Bugs Fixed:  LPP-7354 Presentation Types (partial substrate cleanup)

Technical Reviewer: andre.bargull at udo.edu (pending)
QA Reviewer: max at openlaszlo.org (pending)

Overview:

    `earlySetters` were an attempt by Adam to make a general mechanism,
    but each of the actual usages is a special case.  We don't support
    this generality outside of the kernel (it is handled instead by
    overriding the construct method), so I'm removing it.  It's just a
    lot of extra fragile mechanism that makes the init args more
    difficult to process and interferes with attribute annotation.

Details:

    LzNode, LaszloView, LaszloCanvas:  remove earlySetters lists.

    LzNode: Remove unused `doneClassRoot` flag, unused `defaultSet`
    method.  Handle the previous earlySetters explicitly in
    __LZapplyArgs.  For those that are only used to communicate
    between the compiler and the runtime ($delegates, $classrootdepth,
    $datapath), hoist the former setters inline (but keep the `-1`
    sentinel that indicates they are handled specially in
    __LZapplyArgs).

    LaszloView: Handle `clickregion`, formerly an earlySetter, in
    construct.

    LzState: Clean up class organization to match standard order.
    Remove unneeded initial value for __LZpool.  Make the constructor
    do something useful.  Hide unnecessary documentation of implicit
    event.  Remove 4.1-era deprecated API's.  Handle sorting
    `$delegates` between self and parent explicitly in __LZapplyArgs

Tests:
    smokecheck, selected demos

Files:
M       WEB-INF/lps/lfc/core/LzNode.lzs
M       WEB-INF/lps/lfc/views/LaszloView.lzs
M       WEB-INF/lps/lfc/views/LaszloCanvas.lzs
M       WEB-INF/lps/lfc/helpers/LzState.lzs

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20100604-ptw-7.tar