[Laszlo-reviews] For Review: Change 20100604-bargull-yOg Summary: Methods declared as final don't show up as final in schema

[André Bargull]

Change 20100604-bargull-yOg by bargull at Bargull02 on 2010-06-04 17:36:45
in /home/anba/src/svn/openlaszlo/trunk
for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Methods declared as final don't show up as final in schema

Bugs Fixed: LPP-8803 (Cursor example fails to compile in SWF9)

Technical Reviewer: henry
QA Reviewer: (pending)


Details:
Only the keywords tag was processed when defining final methods, that 
means only methods doc'ed with "@keywords final" were marked as final in 
the schema. So the PropertyReference object did not check 
ASTModifiedDefinition#isFinal(). With this fix a new method was added to 
PropertyReference to add "final" to the "keywords" attribute of the 
generated js2doc element when ASTModifiedDefinition#isFinal() returns true.
Now that final methods are properly marked as final in the schema, the 
cursor example needed to be changed, too.


Tests:
test case from bugreport gives compiler when compiling to all runtimes
inspection of schema/lfc.lzx

Files:
M WEB-INF/lps/lfc/services/LzCursor.lzs
M WEB-INF/lps/server/src/org/openlaszlo/js2doc/PropertyReference.java
M WEB-INF/lps/server/src/org/openlaszlo/js2doc/JS2Doc.java

Changeset: 
http://svn.openlaszlo.org/openlaszlo/patches/20100604-bargull-yOg.tar