[Laszlo-reviews] UPDATED For Review: Change 20100601-hqm-6 Summary: fix for clickable text handcursor in swf9

[Max Carlson]

Can you add a comment to LzTextSprite that points to LPP-8710 so the 
$swf9/10 conditional is clear?  Also, the cursor seems to jump to the 
right when the hand is shown in swf9: adding an x offset of about -4p to 
the resource would help.  Otherwise, approved!

On 6/1/10 7:28 PM, Henry Minsky wrote:
> addressed max's comments, user now not required to include resource manually
>
> Change 20100601-hqm-6 by hqm at badtzmaru.home on 2010-06-01 17:23:21 EDT
>      in /Users/hqm/openlaszlo/trunk2
>      for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary:  fix for clickable text handcursor in swf9
>
> New Features:
>
> Bugs Fixed: LPP-8710
>
> Technical Reviewer: max
> QA Reviewer: ptw
> Doc Reviewer: (pending)
>
> Documentation:
>
> Release Notes:
>
> Overview:
>
> Add an explicit hand cursor resource for swf9, to allow cursor to be changed
> to handcursor when mouse over clickable text
>
> Details:
>
>
> Tests:
>
> Test case below, run with lzr=swf9, mouse cursor should change to button hand when mouseover
> text view.
>
>
> <canvas>
>    <text onclick="Debug.warn('click')">Clickable text should show a hand cursor</text>
> </canvas>
>
>
> Files:
> M       WEB-INF/lps/server/src/org/openlaszlo/compiler/SWF9Writer.java
> M       WEB-INF/lps/lfc/kernel/swf9/LzTextSprite.as
> A       lps/components/lz/resources/handcursor.png
>
>
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20100601-hqm-6.tar

-- 
Regards,
Max Carlson
OpenLaszlo.org