[Laszlo-reviews] For Review: Change 20100601-hqm-c Summary: better error reporting from compiler when using debug eval

[André Bargull]

Approved.

I wonder why you added the try..catch block for the SecurityException? 
SecurityExceptions are RuntimeExceptions, so neither try..catch nor 
throws is required and if the SecurityManager doesn't allow to delete 
files, the exception shouldn't be just ignored.

On 6/1/2010 9:03 PM, Henry Minsky wrote:
> Change 20100601-hqm-c by hqm at badtzmaru.home on 2010-06-01 14:59:03 EDT
>      in /Users/hqm/openlaszlo/trunk
>      for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary:  better error reporting from compiler when using debug eval
>
> New Features:
>
> Bugs Fixed: LPP-9061
>
> Technical Reviewer: ptw
> QA Reviewer: (pending)
> Doc Reviewer: (pending)
>
> Documentation:
>
> Release Notes:
>
> Overview:
>
>
> Details:
>
>
> Tests:
>
> debug eval of a function expression returns a compiler error instead of silent failure
>
> test case below, Note that this ought the be a legal expression and
> not get a compilation error, but there's another bug causing the free
> reference to global 'canvas' to be regarded as undefined. But given that it does
> generate a compile error, it is reported to the user.
>
> lzx>  (function (x) {return canvas})()
> 'Parse error: org.openlaszlo.sc.CompilerError: line unknown: Error: Access of undefined property canvas, in line: return canvas\nline unknown: Error: Access of undefined property Error, in line: if ($lzsc$e is Error&&  $lzsc$e !== lz["$lzsc$thrownError"]) {\nline unknown: Error: Access of undefined property lz, in line: if ($lzsc$e is Error&&  $lzsc$e !== lz["$lzsc$thrownError"]) {\nline unknown: Error: Access of undefined property $lzsc$runtime, in line: $lzsc$runtime.$reportException("[CommonGenerator.parseFragment]", 2, $lzsc$e)'
> lzx>
>
>
> Files:
> M       WEB-INF/lps/server/src/org/openlaszlo/sc/SWF9External.java
>
>
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20100601-hqm-c.tar
>