[Laszlo-reviews] For Review: Change 20100531-bargull-TKS Summary: null pointer exception in lz.ModeManager for debug apps
P T Withington
ptw at pobox.com
Tue Jun 1 09:27:54 PDT 2010
I don't follow your logic here. The comment says you won't enter the loop for the debugger, but it seems to fall through to that loop anyway? Is it missing an `else` ?
Isn't the idea that if you are over the debug console you ignore the mode altogether and just send the mouse event, otherwise you only send the event if the mode permits it?
On 2010-05-30, at 20:33, André Bargull wrote:
> Change 20100531-bargull-TKS by bargull at Bargull02 on 2010-05-31 01:21:49
> in /home/anba/src/svn/openlaszlo/trunk
> for http://svn.openlaszlo.org/openlaszlo/trunk
> Summary: null pointer exception in lz.ModeManager for debug apps
> Bugs Fixed: LPP-9053 (npe in lz.ModeManager.handleMouseEvent() in debug mode)
> Technical Reviewer: hqm
> There was a missing test in an if-condition which led to a null pointer exception. While fixing this, I've restructured the code a bit:
> The test whether a view is a child of the debugger window can be done before entering the loop. If the view is a child of the debugger, simply don't enter the loop, but still send the mouse event. Otherwise just proceed like before.
> see bugreport
> M WEB-INF/lps/lfc/services/LzModeManager.lzs
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20100531-bargull-TKS.tar
More information about the Laszlo-reviews