approved!<br><br>One question, in the code for LzInputTextSprite.prototype.__hideIfNotFocused<br><br><br> if (quirks.textgrabsinputtextfocus) {<br> var s = window.event;<br> if (s && s.srcElement && s.srcElement.owner && s.srcElement.owner instanceof LzTextSprite) {<br>
//Debug.write('text intercepting focus', eventname, s.owner instanceof LzTextSprite);<br> if (eventname == 'onmousedown') {<br> if (lzinppr.__lastshown) lzinppr.__lastshown.gotFocus();<br>
}<br> return;<br> }<br><br>Wouldn't __lastshown always be non-null, because that case was checked for that<br>case at the start of the method? Or does something within __hideIfNotFocused possibly unset that value? <br>
<br><br><br><div class="gmail_quote">On Tue, Jun 2, 2009 at 7:47 PM, Max Carlson <span dir="ltr"><<a href="mailto:max@openlaszlo.org">max@openlaszlo.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Change 20090602-maxcarlson-i by maxcarlson@Bank on 2009-06-02 16:37:12 PDT<br>
in /Users/maxcarlson/openlaszlo/trunk-clean<br>
for <a href="http://svn.openlaszlo.org/openlaszlo/trunk" target="_blank">http://svn.openlaszlo.org/openlaszlo/trunk</a><br>
<br>
Summary: Fix IE to select inputtexts that share the same area as a text<br>
<br>
Bugs Fixed: LPP-8219 - IE DHTML: inputtext focus/selection issues<br>
<br>
Technical Reviewer: hminsky<br>
QA Reviewer: mdemmon<br>
<br>
Details: LzSprite - Add textgrabsinputtextfocus quirk, set to true for IE.<br>
<br>
LzInputTextSprite - __hideIfNotFocused(): Shorten lookups to LzInputTextSprite.prototype. Look at the srcElement of the last event to see if it was an instance of LzTextSprite - this happens when an text is in the same area as an inputtext. If this is the case, focus the inputtext and avoid hiding the shown inputtext.<br>
<br>
Tests: Testcase from LPP-8219 and compose window in webtop mail allows the to: field to be selected in the area that says 'Drag a contact or type for autosuggest'.<br>
<br>
Files:<br>
M WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js<br>
M WEB-INF/lps/lfc/kernel/dhtml/LzInputTextSprite.js<br>
<br>
Changeset: <a href="http://svn.openlaszlo.org/openlaszlo/patches/20090602-maxcarlson-i.tar" target="_blank">http://svn.openlaszlo.org/openlaszlo/patches/20090602-maxcarlson-i.tar</a><br>
</blockquote></div><br><br clear="all"><br>-- <br>Henry Minsky<br>Software Architect<br><a href="mailto:hminsky@laszlosystems.com">hminsky@laszlosystems.com</a><br><br><br>