Well, that change fixes the bug I was seeing in Safari where the downkeys array would fill up with key codes. <br><br><br><br><div class="gmail_quote">On Tue, Jun 2, 2009 at 10:37 AM, André Bargull <span dir="ltr"><<a href="mailto:andre.bargull@uni-dortmund.de">andre.bargull@uni-dortmund.de</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Hm, there is _no_ issue, just too much concurrent changes on my local machine. Sorry for that!<div>
<div></div><div class="h5"><br>
<br>
<br>
On 6/2/2009 4:33 PM, André Bargull wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Ups, there is still an issue somewhere. (I shouldn't compile the debug-lfc and test an application in non-debug mode :-P )<br>
<br>
<br>
On 6/2/2009 4:27 PM, André Bargull wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
These are just the changes for LzKeyboardKernel. We still need to decide whether "updateControlKeys()" needs to handle the 'metaKey' for LPP-8210.<br>
<br>
<br>
Change 20090602-bargull-GPN by bargull@dell--p4--2-53 on 2009-06-02 15:54:52<br>
in /home/Admin/src/svn/openlaszlo/trunk<br>
for <a href="http://svn.openlaszlo.org/openlaszlo/trunk" target="_blank">http://svn.openlaszlo.org/openlaszlo/trunk</a><br>
<br>
Summary: DHTML: add "updateControlKeys" to LzKeyboardKernel<br>
<br>
New Features:<br>
<br>
Bugs Fixed: LPP-8218 - DHTML: issues with contextmenu onmenuopen, dragging (partial)<br>
<br>
Technical Reviewer: max, ptw<br>
QA Reviewer: hqm<br>
Doc Reviewer: (pending)<br>
<br>
Documentation:<br>
<br>
Release Notes:<br>
<br>
Details:<br>
Call "updateControlKeys()" instead of "__keyboardEvent()" for mouse-events.<br>
Set "cancelBubble" and "returnValue" after invoking "updateControlKeys()" to mimic old behaviour (this is actually wrong, see LPP-8200, but reduces testing effort right now). "keyCode" is set to 0 for mouse-events in IE, Opera, Safari, so you only need to test for keyCode==0 (Firefox is irrelevant in this case, because it sets keyCode to `undefined` for mouse-events).<br>
<br>
<br>
<br>
Tests:<br>
test/lfc/legals/keyboardandmouse.lzx?lzr=dhtml still works as expected<br>
<br>
<br>
Files:<br>
M WEB-INF/lps/lfc/kernel/dhtml/LzKeyboardKernel.js<br>
M WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js<br>
M WEB-INF/lps/lfc/kernel/dhtml/LzMouseKernel.js<br>
<br>
Changeset: <a href="http://svn.openlaszlo.org/openlaszlo/patches/20090602-bargull-GPN.tar" target="_blank">http://svn.openlaszlo.org/openlaszlo/patches/20090602-bargull-GPN.tar</a><br>
<br>
<br>
</blockquote>
<br>
</blockquote>
</div></div></blockquote></div><br><br clear="all"><br>-- <br>Henry Minsky<br>Software Architect<br><a href="mailto:hminsky@laszlosystems.com">hminsky@laszlosystems.com</a><br><br><br>