<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">I'm one review behind, but approved...<div><br><div><div>On Nov 19, 2008, at 4:33 PM, Henry Minsky wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>Change 20081119-hqm-q by <a href="mailto:hqm@badtzmaru.home">hqm@badtzmaru.home</a> on 2008-11-19 16:23:53 EST<br> in /Users/hqm/openlaszlo/trunk4<br> for <a href="http://svn.openlaszlo.org/openlaszlo/trunk">http://svn.openlaszlo.org/openlaszlo/trunk</a><br><br>Summary: more fixes for swf9 <import><br><br>New Features:<br><br>Bugs Fixed:<br><br>Technical Reviewer: dda<br>QA Reviewer: ptw<br>Doc Reviewer: (pending)<br><br>Documentation:<br><br>Release Notes:<br><br>Details:<br><br>+ In order prevent the LFC from getting compiled into each loadable<br>library, I added the the compiler directive -external-library-path to<br>exclude it. I needed to then explicitly include a base application<br>class so that the file would compile into a real application swf. I<br>couldn't figure out how to get my LzBaseLoadableLib class to be<br>included from the LFC after I had excluded the whole library, so I<br>just made the SWF9Writer emit a little base class which extends Sprite<br>for the library.<br><br>I was never able to make the Flash "runtime shared library" feature<br>work for the LFC, I need to figure out why that is. But we don't need<br>it right now, because the LFC isn't getting copied into each loadable<br>library anymore.<br><br>Tests:<br>test/snippets/import-class.lzx<br>test/snippets/import-resource.lzx<br><br>generated library .swf files are nice and small now, they don't have the LFC in them<br><br>Files:<br>M WEB-INF/lps/server/src/org/openlaszlo/sc/SWF9External.java<br>M WEB-INF/lps/server/src/org/openlaszlo/sc/Compiler.java<br>M WEB-INF/lps/server/src/org/openlaszlo/compiler/DataCompiler.java<br>M WEB-INF/lps/server/src/org/openlaszlo/compiler/ImportCompiler.java<br>M WEB-INF/lps/server/src/org/openlaszlo/compiler/SWF9Writer.java<br><br><br>Changeset: <a href="http://svn.openlaszlo.org/openlaszlo/patches/20081119-hqm-q.tar">http://svn.openlaszlo.org/openlaszlo/patches/20081119-hqm-q.tar</a><br></div></blockquote></div><br><div> <span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><br class="Apple-interchange-newline">--</div><div><br>Don Anderson<br>Java/C/C++, Berkeley DB, systems consultant<br><br>voice: 617-547-7881<br>email: <a href="mailto:dda@ddanderson.com">dda@ddanderson.com</a><br>www: <a href="http://www.ddanderson.com/">http://www.ddanderson.com</a><br></div></div></span></span><br class="Apple-interchange-newline"></div></span></div></span><br class="Apple-interchange-newline"> </div><br></div></body></html>