<html>
<body>
Thanks for spotting these! I'm working on another changeset to address
some other issues as well. I will modify convert_setters.pl to display a
list of all setters in component code for manual review.<br><br>
Thanks!<br><br>
Phil<br><br>
<br><br>
<blockquote type=cite class=cite cite="">I've spotted four issues while
skimming the diff:<br>
- recursion in "tooltipview" and "baseedittext"<br>
- an old setter in "vslider"<br>
- some debug-code in "basecombobox#_applystyle"<br>
<br>
> ---
lps/components/incubator/tooltip/tooltipview.lzx
(revision 10889)<br>
> +++
lps/components/incubator/tooltip/tooltipview.lzx
(working copy)<br>
> - <attribute name="text"
value="" type="html" <br>
> setter="this.setText(text)" /><br>
> + <attribute name="text"
value="" type="html" <br>
> setter="this.setAttribute('text', text)" /><br>
> <br>
> <br>
> --- lps/components/incubator/baseedittext.lzx
(revision 10889)<br>
> +++ lps/components/incubator/baseedittext.lzx
(working copy)<br>
> - <attribute
name="height" value="20" <br>
> setter="this.setHeight(height)"/><br>
> + <attribute
name="height" value="20" <br>
> setter="this.setAttribute('height', height)"/><br>
> <br>
> <br>
> --- lps/components/incubator/vslider.lzx (revision
10889)<br>
> +++ lps/components/incubator/vslider.lzx (working
copy)<br>
> <method
name="setY" args="v"><br>
>
-
super.setY(v);<br>
>
+
super.setAttribute('y', v);<br>
> <br>
> <br>
> --- lps/components/base/basecombobox.lzx (revision
10889)<br>
> +++ lps/components/base/basecombobox.lzx (working
copy)<br>
> @@ -640,6 +640,7 @@<br>
> <method
name="_applystyle" args="s"><br>
>
if (this.style != null) {<br>
>
if (editable) {<br>
> +Debug.warn("textfieldcolor", s.textfieldcolor, s);<br>
<br>
<br>
<br>
> Approved pro forma, I'd like to see ant lztest and ant lzunit pass,
<br>
> and the nightly megatest.<br>
> <br>
> On 2008-09-05, at 16:51EDT, Philip Romanik wrote:<br>
> <br>
> <br>
>> > Change 20080905-Philip-4 by Philip@Philip-DC on 2008-09-05
16:39:02 <br>
>> > EDT<br>
>> > in
/cygdrive/f/laszlo/svn/src/svn/openlaszlo/trunk<br>
>> > for
<a href="http://svn.openlaszlo.org/openlaszlo/trunk">
http://svn.openlaszlo.org/openlaszlo/trunk</a><br>
>> ><br>
>> > Summary: Modify components to use setAttribute instead of
setX<br>
>> ><br>
>> > New Features:<br>
>> ><br>
>> > Bugs Fixed: LPP-5644 (partial)<br>
>> ><br>
>> > Technical Reviewer: ptw<br>
>> > QA Reviewer: (pending)<br>
>> > Doc Reviewer: (pending)<br>
>> ><br>
>> > Documentation:<br>
>> ><br>
>> > Release Notes:<br>
>> ><br>
>> > Details:<br>
>> > I ran a script I wrote
(/WEB-INF/lps/server/bin/convert_setters.pl)<br>
>> > on the components. This modifies a call like,<br>
>> ><br>
>> > this.setText(t) ==>
this.setAttribute('text', t);<br>
>> ><br>
>> > The tool isn't perfect because some classes define a local
methods <br>
>> > (ie. setText()) that doesn't derive from a view. However,
it is <br>
>> > >90% correct.<br>
>> ><br>
>> > There are still some setters in other non-view files I need
to <br>
>> > convert.<br>
>> ><br>
>> > I only modified the calendar demo app. I will modify the
other <br>
>> > apps/ tests as a separate changeset.<br>
>> ><br>
>> > I am checking this code in. The most interesting file to
look at is <br>
>> > convert_setters.pl. It is based upon
convert_required.pl.<br>
>> ><br>
>> ><br>
>> ><br>
>> > Tests:<br>
>> > component examples work again. recursion errors trying to
run <br>
>> > calendar are gone. deprecated messages about using setX in
the <br>
>> > components are gone.<br>
>> ><br>
>> ><br>
>> > Files:<br>
>> > A
WEB-INF/lps/server/bin/convert_setters.pl<br>
>> > M
lps/components/queens-charts/shared/piepiece.lzx<br>
>> > M
lps/components/queens-charts/shared/wholepie.lzx<br>
>> > M
lps/components/queens-charts/shared/chartzoomer.lzx<br>
>> > M
lps/components/queens-charts/shared/legend.lzx<br>
>> > M
lps/components/queens-charts/shared/label.lzx<br>
>> > M
lps/components/rpc/soap.lzx<br>
>> > M
lps/components/debugger/debugger.lzx<br>
>> > M
lps/components/debugger/newcontent.lzx<br>
>> > M
lps/components/debugger/scrollingtext.lzx<br>
>> > M
lps/components/charts/columnchart/columnchartplotarea.lzx<br>
>> > M
lps/components/charts/piechart/piepiece.lzx<br>
>> > M
lps/components/charts/addon/slider/slider.lzx<br>
>> > M
lps/components/charts/addon/zoomarea.lzx<br>
>> > M
lps/components/charts/barchart/barchartplotarea.lzx<br>
>> > M
lps/components/charts/common/tickmarklabel.lzx<br>
>> > M
lps/components/charts/common/valuepoints.lzx<br>
>> > M
lps/components/charts/common/datamarker.lzx<br>
>> > M
lps/components/charts/common/horizontalaxis.lzx<br>
>> > M
lps/components/charts/common/label.lzx<br>
>> > M
lps/components/charts/common/valueregion.lzx<br>
>> > M
lps/components/charts/common/valueline.lzx<br>
>> > M
lps/components/charts/common/datatip.lzx<br>
>> > M
lps/components/charts/common/rectangularchart.lzx<br>
>> > M
lps/components/charts/common/legend.lzx<br>
>> > M
lps/components/charts/common/databar.lzx<br>
>> > M
lps/components/charts/common/verticalaxis.lzx<br>
>> > M
lps/components/charts/linechart/linechartplotarea.lzx<br>
>> > M
lps/components/lz/gridcolumn.lzx<br>
>> > M
lps/components/lz/button.lzx<br>
>> > M
lps/components/lz/tabelement.lzx<br>
>> > M
lps/components/lz/listitem.lzx<br>
>> > M
lps/components/lz/basefloatinglist.lzx<br>
>> > M
lps/components/lz/hscrollbar.lzx<br>
>> > M
lps/components/lz/simpletext.lzx<br>
>> > M
lps/components/lz/floatinglist.lzx<br>
>> > M
lps/components/lz/menu.lzx<br>
>> > M
lps/components/lz/alert.lzx<br>
>> > M
lps/components/lz/combobox.lzx<br>
>> > M
lps/components/lz/vscrollbar.lzx<br>
>> > M
lps/components/lz/list.lzx<br>
>> > M
lps/components/lz/datepicker.lzx<br>
>> > M
lps/components/lz/slider.lzx<br>
>> > M
lps/components/lz/scrollbar.lzx<br>
>> > M
lps/components/lz/windowpanel.lzx<br>
>> > M
lps/components/lz/edittext.lzx<br>
>> > M
lps/components/lz/gridtext.lzx<br>
>> > M
lps/components/lz/datacombobox.lzx<br>
>> > M
lps/components/incubator/lzcombobox_class.lzx<br>
>> > M
lps/components/incubator/custombutton.lzx<br>
>> > M
lps/components/incubator/tooltip/tooltipview.lzx<br>
>> > M
lps/components/incubator/tooltip/tooltip.lzx<br>
>> > M
lps/components/incubator/newvscrollbar.lzx<br>
>> > M
lps/components/incubator/lwzCalendar/lwzEncalendar.lzx<br>
>> > M
lps/components/incubator/roundrectbutton.lzx<br>
>> > M
lps/components/incubator/baseslider.lzx<br>
>> > M
lps/components/incubator/ulink.lzx<br>
>> > M
lps/components/incubator/baseedittext.lzx<br>
>> > M
lps/components/incubator/stylishbutton.lzx<br>
>> > M
lps/components/incubator/validators/basevalidator.lzx<br>
>> > M
lps/components/incubator/defaultlistitem.lzx<br>
>> > M
lps/components/incubator/uploader/fileuploadlist.lzx<br>
>> > M
lps/components/incubator/newhscrollbar.lzx<br>
>> > M
lps/components/incubator/colorslider.lzx<br>
>> > M
lps/components/incubator/autocompletecombobox.lzx<br>
>> > M
lps/components/incubator/test/libflickr-test.lzx<br>
>> > M
lps/components/incubator/draglib.lzx<br>
>> > M
lps/components/incubator/opttree/opttree.lzx<br>
>> > M
lps/components/incubator/vslider.lzx<br>
>> > M
lps/components/incubator/stepper.lzx<br>
>> > M
lps/components/incubator/lzeditcombobox.lzx<br>
>> > M
lps/components/incubator/rich-text/linkdialog.lzx<br>
>> > M
lps/components/incubator/rich-text/formatfontcolor.lzx<br>
>> > M
lps/components/incubator/borderinput.lzx<br>
>> > M
lps/components/extensions/html.lzx<br>
>> > M
lps/components/extensions/drawview.lzx<br>
>> > M
lps/components/extensions/av/videoview.lzx<br>
>> > M
lps/components/extensions/views/richinputtext.lzx<br>
>> > M
lps/components/utils/performance/library.lzx<br>
>> > M
lps/components/utils/diagnostic/inittimer.lzx<br>
>> > M
lps/components/utils/diagnostic/inspector/colormenu.lzx<br>
>> > M
lps/components/utils/diagnostic/inspector/inspector.lzx<br>
>> > M
lps/components/utils/diagnostic/frametimer.lzx<br>
>> > M
lps/components/utils/replicator/replicator.lzx<br>
>> > M
lps/components/utils/traits/cssable.lzx<br>
>> > M
lps/components/base/basebutton.lzx<br>
>> > M
lps/components/base/basegridrow.lzx<br>
>> > M
lps/components/base/basescrollbar.lzx<br>
>> > M
lps/components/base/basewindow.lzx<br>
>> > M
lps/components/base/basecombobox.lzx<br>
>> > M
lps/components/base/basetabslider.lzx<br>
>> > M
lps/components/base/basefocusview.lzx<br>
>> > M
lps/components/base/basedatepicker.lzx<br>
>> > M
lps/components/base/basetrackgroup.lzx<br>
>> > M
lps/components/base/baseslider.lzx<br>
>> > M
lps/components/base/basegrid.lzx<br>
>> > M
lps/components/base/basedatacombobox.lzx<br>
>> > M
lps/components/base/basegridcolumn.lzx<br>
>> > M
lps/components/base/style.lzx<br>
>> > M
demos/calendar/simpletimelayout.lzx<br>
>> > M
demos/calendar/cal-button.lzx<br>
>> > M
demos/calendar/calendar.lzx<br>
>> > M
demos/calendar/vscrollbar.lzx<br>
>> > M
demos/calendar/infopanel.lzx<br>
>> > M demos/calendar/day.lzx<br>
>> > M
demos/calendar/event.lzx<br>
>> > M
demos/calendar/eventselector.lzx<br>
>> > M
demos/calendar/gridsliderlayout.lzx<br>
>> > M
demos/calendar/selected-daylook.lzx<br>
>> > M
demos/calendar/basepanel.lzx<br>
>> > M
demos/calendar/textbox.lzx<br>
>> ><br>
>> > Changeset: <br>
>> >
<a href="http://svn.openlaszlo.org/openlaszlo/patches/20080905-Philip-4.tar">
http://svn.openlaszlo.org/openlaszlo/patches/20080905-Philip-4.tar</a><br>
>> ><br>
>> <br>
> <br>
> </blockquote></body>
</html>