<div dir="ltr"><br><br><div class="gmail_quote">On Thu, Sep 4, 2008 at 7:41 PM, Donald Anderson <span dir="ltr"><<a href="mailto:dda@ddanderson.com">dda@ddanderson.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div style="word-wrap:break-word">A few items:<div><br></div><div>1) I'm pretty sure the build.sh/build.bat produced will be broken,</div><div>it won't have the pathname of the compile command. That's a 'nice to have'.</div>
<div></div></div></blockquote><div><br></div><div>Yeah that's a good point, I meant to make sure that the printed command stayed correct</div><div>but forgot about it halfway though. </div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div style="word-wrap:break-word"><div><br></div><div><div>2)</div><div>+ exitval = flex2.compiler.util.ThreadLocalToolkit.errorCount();</div><div>Couldn't find any doc for ThreadLocalToolkit. Are the errors additive,</div>
<div>or will they be reset to 0 on each call into the compiler? (i.e. I'm</div><div>worried about an error being 'sticky' to the next compile - I guess</div><div>it would only result in a stray FAIL println to the error console).</div>
</div></div></blockquote><div><br></div><div>Good question. That is what the flex "mxmlc" and "compc" utility classes are calling for</div><div>their exit val, I'll check if it needs to be/can be reset</div>
<div>somehow. </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div style="word-wrap:break-word"><div><div></div><div><br></div><div>3) If we end up going with this approach then execCompileCommand has</div>
<div>just become dead code. If we want to keep both approaches around (perhaps</div><div>extern compile as a backup), then this code should be refactored to get</div><div>better sharing.</div><div><br></div><div>Otherwise, approved.</div>
</div></div></blockquote><div><br></div><div>I do want to keep the execCompileComand code around and working in case we </div><div>need to go back to using it. </div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div style="word-wrap:break-word"><div><div></div><div><br></div></div><div><div><div></div><div class="Wj3C7c"><div><div>On Sep 4, 2008, at 11:50 AM, Henry Minsky wrote:</div><br><blockquote type="cite"><div dir="ltr">I'm going to check this in now, so it gets in the nightly build so that Mamye can test<div>
it as soon as possible. </div><div><br></div><div><br><br><div class="gmail_quote">On Thu, Sep 4, 2008 at 11:17 AM, Henry Minsky <span dir="ltr"><<a href="mailto:henry.minsky@gmail.com" target="_blank">henry.minsky@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Change 20080904-hqm-J by <a href="mailto:hqm@badtzmaru.home" target="_blank">hqm@badtzmaru.home</a> on 2008-09-04 11:11:21 EDT<br>
in /Users/hqm/openlaszlo/trunk<br> for <a href="http://svn.openlaszlo.org/openlaszlo/trunk" target="_blank">http://svn.openlaszlo.org/openlaszlo/trunk</a><br> <br> Summary: call flex compiler classes directly from jar file<br>
<br> New Features:<br> <br> Bugs Fixed: LPP-6309<br> <br> Technical Reviewer: dda<br> QA Reviewer: mamye<br> Doc Reviewer: (pending)<br> <br> Documentation:<br> <br> Release Notes:<br> <br> Details:<br> <br> <br> Tests:<br>
<br> Mamye, please make sure that when this is built as a nightly, that is installs and runs<br> on MacOS and can compiler swf9 properly there, when installed in a path in /Applications<br> which has spaces in the pathname.<br>
<br> Files:<br> M WEB-INF/lps/server/src/org/openlaszlo/sc/SWF9External.java<br> <br> Changeset: <a href="http://svn.openlaszlo.org/openlaszlo/patches/20080904-hqm-J.tar" target="_blank">http://svn.openlaszlo.org/openlaszlo/patches/20080904-hqm-J.tar</a><br>
</blockquote></div><br><br clear="all"><br>-- <br>Henry Minsky<br>Software Architect<br><a href="mailto:hminsky@laszlosystems.com" target="_blank">hminsky@laszlosystems.com</a><br><br><br> </div></div></blockquote></div>
<br></div></div><font color="#888888"><div> <span style="border-collapse:separate;color:rgb(0, 0, 0);font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:auto;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><div style="word-wrap:break-word">
<span style="border-collapse:separate;color:rgb(0, 0, 0);font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><div style="word-wrap:break-word">
<span style="border-collapse:separate;color:rgb(0, 0, 0);font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><span style="border-collapse:separate;color:rgb(0, 0, 0);font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><div style="word-wrap:break-word">
<div><br>--</div><div><br>Don Anderson<br>Java/C/C++, Berkeley DB, systems consultant<br><br>voice: 617-547-7881<br>email: <a href="mailto:dda@ddanderson.com" target="_blank">dda@ddanderson.com</a><br>www: <a href="http://www.ddanderson.com/" target="_blank">http://www.ddanderson.com</a><br>
</div></div></span></span><br></div></span></div></span><br> </div><br></font></div></div></blockquote></div><br><br clear="all"><br>-- <br>Henry Minsky<br>Software Architect<br><a href="mailto:hminsky@laszlosystems.com">hminsky@laszlosystems.com</a><br>
<br><br>
</div>