<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Approved.<div><br><div><div>On Aug 25, 2008, at 2:18 PM, Henry Minsky wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>Change 20080825-hqm-A by <a href="mailto:hqm@badtzmaru.home">hqm@badtzmaru.home</a> on 2008-08-25 14:12:17 EDT<br> in /Users/hqm/openlaszlo/trunk<br> for <a href="http://svn.openlaszlo.org/openlaszlo/trunk">http://svn.openlaszlo.org/openlaszlo/trunk</a><br><br>Summary: fix for debug eval feature in swf9<br><br>New Features:<br><br>Bugs Fixed:<br><br>Technical Reviewer: dda<br>QA Reviewer: pbr<br>Doc Reviewer: (pending)<br><br>Documentation:<br><br>Release Notes:<br><br>Details:<br><br>Recently LFCApplication was given a new "sprite" arg to its constructor.<br>The code for DebugEvaluate uses the same code paths in swf9generator for<br>compiling a "debug eval" app, which generates a "sprite" arg in its constructor now,<br>but the app is executed as a standalone movie that gets loaded at runtime, and thus is not called<br>with any arg to its constructor.<br><br>I made the code in parsetreeprinter make the sprite arg optional, which covers both cases now.<br><br>There might be a better way to fix this, to make the debug eval code path less intertwined with the main<br>app compilation.<br><br><br><br>Tests:<br> run an app which has the debugger displayed<br><br><canvas oninit="Debug.write('foo')"/><br><br>and then type an expression into the eval input field and see<br>if it prints the result<br><br><br>Files:<br>M WEB-INF/lps/server/src/org/openlaszlo/sc/SWF9External.java<br>M WEB-INF/lps/server/src/org/openlaszlo/sc/SWF9ParseTreePrinter.java<br><br><br>Changeset: <a href="http://svn.openlaszlo.org/openlaszlo/patches/20080825-hqm-A.tar">http://svn.openlaszlo.org/openlaszlo/patches/20080825-hqm-A.tar</a><br></div></blockquote></div><br><div> <span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><br class="Apple-interchange-newline">--</div><div><br>Don Anderson<br>Java/C/C++, Berkeley DB, systems consultant<br><br>voice: 617-547-7881<br>email: <a href="mailto:dda@ddanderson.com">dda@ddanderson.com</a><br>www: <a href="http://www.ddanderson.com/">http://www.ddanderson.com</a><br></div></div></span></span><br class="Apple-interchange-newline"></div></span></div></span><br class="Apple-interchange-newline"> </div><br></div></body></html>