<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Sorry for the late review -<div>Approved as long there are tests for the various code paths.</div><div><br></div><div>I see why you wanted a macro expander for this, it's tangled stuff.</div><div><br></div><div><div><div>On Jul 17, 2008, at 8:58 PM, P T Withington wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>Change 20080717-ptw-e by <a href="mailto:ptw@dueling-banjos.local">ptw@dueling-banjos.local</a> on 2008-07-17 19:51:51 EDT<br> in /Users/ptw/OpenLaszlo/dingdong-clean<br> for <a href="http://svn.openlaszlo.org/openlaszlo/trunk">http://svn.openlaszlo.org/openlaszlo/trunk</a><br><br>Summary: Reinstate setAttribute inlining<br><br>Bugs Fixed:<br>LPP-5622 'Re-enable setAttribute inlining'<br><br>Technical Reviewer: dda (pending)<br>QA Reviewer: promanik (pending)<br><br>Details:<br> LzEventable: remove debug code<br><br> JavascriptGenerator, CodeGenerator: update setAttribute inlining<br> code to match the new way, and enable it.<br><br>Tests:<br> smokecheck, ant lztest<br><br>Files:<br>M WEB-INF/lps/lfc/core/LzEventable.lzs<br>M WEB-INF/lps/server/src/org/openlaszlo/sc/JavascriptGenerator.java<br>M WEB-INF/lps/server/src/org/openlaszlo/sc/CodeGenerator.java<br>M WEB-INF/lps/server/build.xml<br><br>Changeset: <a href="http://svn.openlaszlo.org/openlaszlo/patches/20080717-ptw-e.tar">http://svn.openlaszlo.org/openlaszlo/patches/20080717-ptw-e.tar</a><br></div></blockquote></div><br><div apple-content-edited="true"> <span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div>--</div><div><br></div><div>Donald Anderson</div><div>Systems Developer</div><div><a href="mailto:dda@laszlosystems.com">dda@laszlosystems.com</a></div><div><br></div><div><br></div></div></span><br class="Apple-interchange-newline"> </div><br></div></body></html>