<html><body bgcolor="#FFFFFF"><div>The override us automatic, I think it is the public that is screwing the test case. If toString is not public it won't be invoked by implicit string conversions. So I declared it public in my patch that Max was testing. But the test must override but not declare public. I'm pretty sure that is the conflict. <br><br>On May 2, 2008, at 21:55, "Henry Minsky" <<a href="mailto:hminsky@laszlosystems.com">hminsky@laszlosystems.com</a>> wrote:<br><br></div><div></div><blockquote type="cite"><div>Aren't the override keywords supposed to be inserted automatically ? <br>Do we need to declare toString on something in the lfc.lzx schema file so that the compiler<br>knows to insert an override? <br><br><div class="gmail_quote">
On Fri, May 2, 2008 at 5:18 PM, P T Withington <<a href="mailto:ptw@pobox.com"><a href="mailto:ptw@pobox.com">ptw@pobox.com</a></a>> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Well toString has to be a public override for it to work, so, I think the example will have to be updated.<div><div></div><div class="Wj3C7c"><br>
<br>
On May 2, 2008, at 14:09, Max Carlson <<a href="mailto:max@openlaszlo.org" target="_blank"><a href="mailto:max@openlaszlo.org">max@openlaszlo.org</a></a>> wrote:<br>
<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Your example works, but <a href="http://localhost:8080/trunk/examples/modeexample.lzx?lzr=swf9" target="_blank"><a href="http://localhost:8080/trunk/examples/modeexample.lzx?lzr=swf9">http://localhost:8080/trunk/examples/modeexample.lzx?lzr=swf9</a></a> now gives a compiler error:<br>
org.openlaszlo.sc.CompilerError: line 366: Error: Incompatible override, in line: override function toString () {<br>
<br>
P T Withington wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Change 20080502-ptw-H by <a href="mailto:ptw@dueling-banjos.home">ptw@dueling-banjos.home</a> on 2008-05-02 06:48:32 EDT<br>
in /Users/ptw/OpenLaszlo/ringding-2/WEB-INF/lps/lfc<br>
for <a href="http://svn.openlaszlo.org/openlaszlo/trunk/WEB-INF/lps/lfc" target="_blank"><a href="http://svn.openlaszlo.org/openlaszlo/trunk/WEB-INF/lps/lfc">http://svn.openlaszlo.org/openlaszlo/trunk/WEB-INF/lps/lfc</a></a><br>
Summary: Make handler trampoline work in swf9<br>
Bugs Fixed:<br>
LPP-5818 'Warn when methods registered for events aren't expecting exactly one argument from sendEvent()'<br>
Technical Reviewer: hminsky (pending)<br>
QA Reviewer: max (pending)<br>
Details:<br>
LzFormattter: Type and default args for swf9, work around switch<br>
verifier error (must have break on final case).<br>
*: toString must be public to have it seen by string coercion<br>
Tests:<br>
This now runs in swf9, demonstrating that the wrapper to handle<br>
the missing argument is being installed.<br>
<canvas><br>
<simplelayout /><br>
<text name="output" clickable="true" text="Click Me!"/><br>
<method name="handleMe"><br>
output.format("Clicked!");<br>
</method><br>
<handler name="onclick" reference="output" method="handleMe" /><br>
</canvas><br>
Files:<br>
M kernel/swf/LzLibrary.lzs<br>
M kernel/dhtml/LzLibrary.js<br>
M services/LzURL.js<br>
M services/LzIdle.lzs<br>
M debugger/LzMemory.lzs<br>
M core/LzMiniNode.lzs<br>
M core/LzNode.lzs<br>
M views/LzText.lzs<br>
M views/LaszloCanvas.lzs<br>
M helpers/LzFont.lzs<br>
M helpers/LzSelectionManager.lzs<br>
M events/LaszloEvents.lzs<br>
M controllers/LzAnimatorGroup.lzs<br>
M controllers/LaszloLayout.lzs<br>
M controllers/LaszloAnimation.lzs<br>
M data/LzLazyReplicationManager.lzs<br>
M data/LzReplicationManager.lzs<br>
M data/LzDatapointer.lzs<br>
M data/LzDataText.lzs<br>
M data/LzDataElement.lzs<br>
M data/LzDataset.lzs<br>
M data/LzDatapath.lzs<br>
M data/LzResizeReplicationManager.lzs<br>
M data/LzParsedPath.lzs<br>
M data/LzParam.lzs<br>
M data/LzDataAttrBind.lzs<br>
M compiler/LzFormatter.lzs<br>
Changeset: <a href="http://svn.openlaszlo.org/openlaszlo/patches/20080502-ptw-H.tar" target="_blank"><a href="http://svn.openlaszlo.org/openlaszlo/patches/20080502-ptw-H.tar">http://svn.openlaszlo.org/openlaszlo/patches/20080502-ptw-H.tar</a></a><br>
</blockquote>
<br>
-- <br>
Regards,<br>
Max Carlson<br>
OpenLaszlo.org<br>
</blockquote>
</div></div></blockquote></div><br><br clear="all"><br>-- <br>Henry Minsky<br>Software Architect<br><a href="mailto:hminsky@laszlosystems.com"><a href="mailto:hminsky@laszlosystems.com">hminsky@laszlosystems.com</a></a><br><br>
</div></blockquote></body></html>