<html>
<body>
Approved.<br><br>
<blockquote type=cite class=cite cite="">Change 20071206-dda-3 by
<a href="mailto:dda@freddie.local">dda@freddie.local</a> on 2007-12-06
19:04:34 EST<br>
in
/Users/dda/laszlo/src/svn/openlaszlo/trunk<br>
for
<a href="http://svn.openlaszlo.org/openlaszlo/trunk">
http://svn.openlaszlo.org/openlaszlo/trunk</a><br>
<br>
Summary: Separate ParseTreePrinter into its own class<br>
<br>
New Features: none, only code reorg to make life easier for
development.<br>
<br>
Bugs Fixed: LPP-4786<br>
<br>
Technical Reviewer: ptw<br>
QA Reviewer: promanik<br>
Doc Reviewer: (pending)<br>
<br>
Documentation: none<br>
<br>
Release Notes: none<br>
<br>
Details:<br>
ParseTreePrinter was an inner class within the
Compiler class. <br>
In SWF9, we<br>
separated this class to its own file to make it
more natural to subclass.<br>
However, ongoing maintenance and additions to
Compiler.ParseTreePrinter<br>
are troublesome to merge when they appear in
devildog (each change<br>
must be hand merged).<br>
<br>
The diff associated with this review is messier
than it could be -<br>
since it shows all the changes made to this file
after it was copied<br>
into the tree from devildog. I essentially
removed anything<br>
SWF9 related - the new ParseTreePrinter.java is
pretty much<br>
an exact copy of Compiler.ParseTreePrinter with
only minor<br>
formatting changes and a couple changes needed
to make<br>
it compile. It might be better to compare
(old) Compiler.ParseTreePrinter<br>
with (new) ParseTreePrinter.java using 'diff
-b'.<br>
<br>
Tests:<br>
Ran smokecheck<br>
<br>
Compared the binaries for the LFCs before and
after this change.<br>
<br>
Files:<br>
M
WEB-INF/lps/server/src/org/openlaszlo/sc/ReferenceCollector.java<br>
M
WEB-INF/lps/server/src/org/openlaszlo/sc/JavascriptGenerator.java<br>
M
WEB-INF/lps/server/src/org/openlaszlo/sc/CommonGenerator.java<br>
M
WEB-INF/lps/server/src/org/openlaszlo/sc/Compiler.java<br>
M
WEB-INF/lps/server/src/org/openlaszlo/sc/CodeGenerator.java<br>
A +
WEB-INF/lps/server/src/org/openlaszlo/sc/ParseTreePrinter.java<br>
M
WEB-INF/lps/server/src/org/openlaszlo/compiler/LibraryWriter.java<br>
<br>
Changeset:
<a href="http://svn.openlaszlo.org/openlaszlo/patches/20071206-">
http://svn.openlaszlo.org/openlaszlo/patches/20071206-</a><br>
dda-3.tar<br>
<br>
<br>
<br>
--<br>
<br>
Don Anderson<br>
Java/C/C++, Berkeley DB, systems consultant<br>
<br>
Voice: 617-547-7881<br>
Email:
<a href="mailto:dda@ddanderson.com">dda@ddanderson.com</a><br>
WWW:
<a href="http://www.ddanderson.com">http://www.ddanderson.com</a><br>
</blockquote></body>
</html>