approved!<br><br><div><span class="gmail_quote">On 11/1/07, <b class="gmail_sendername">André Bargull</b> <<a href="mailto:a.bargull@intensis.de">a.bargull@intensis.de</a>> wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Henry, I'm still waiting for your review of this changeset. Any news for me?<br><br>- André<br><br>-------- Original-Message --------<br>Subject: For Review: Change 20071020-bargull-2 Summary: Two<br>improvements for
LzHTTPLoader.js<br>Date: Sat, 20 Oct 2007 17:35:58 +0200<br>From: André Bargull <<a href="mailto:a.bargull@intensis.de">a.bargull@intensis.de</a>><br>To: Henry Minsky <<a href="mailto:henry.minsky@gmail.com">
henry.minsky@gmail.com</a>><br>CC: <a href="mailto:laszlo-dev@openlaszlo.org">laszlo-dev@openlaszlo.org</a><br><br><br><br>Change 20071020-bargull-2 by bargull@dell--p4--2-53 on 2007-10-20 17:11:11<br>in /home/Admin/src/svn/openlaszlo/trunk
<br>for <a href="http://svn.openlaszlo.org/openlaszlo/trunk">http://svn.openlaszlo.org/openlaszlo/trunk</a><br><br>Summary: Two improvements for LzHTTPLoader<br><br>New Features:<br><br>Bugs Fixed:<br>LPP-4945 - Improvements for "
LzHTTPLoader.prototype.loadXMLDoc"<br><br>Technical Reviewer: hminsky<br>QA Reviewer: (pending)<br>Doc Reviewer: (pending)<br><br>Documentation:<br><br>Release Notes:<br><br>Details:<br>Timeout checking was not removed for erroneous requests in non-proxied
<br>DHTML applications, this is now fixed.<br>To test this, you need to uncomment the Debug.write statements in<br>LzHTTPLoader.prototype.removeTimeout and<br>LzHTTPLoader.__LZcheckXMLHTTPTimeouts. You can see, that erroneous
<br>requests were still checked against timeouts.<br>Additionally, the try..catch block in<br>"LzHTTPLoader.prototype.loadXMLDoc" has been shortened, because it was<br>catching just too much errors. Sounds strange, but the block was solely
<br>added to catch possible errors in Firefox when you read out<br>XMLHttpRequest.status on a aborted request and just for this error!<br><br><br>Tests:<br><br>Files:<br>M WEB-INF/lps/lfc/kernel/dhtml/LzHTTPLoader.js<br><br>
Changeset:<br><a href="http://svn.openlaszlo.org/openlaszlo/patches/20071020-bargull-2.tar">http://svn.openlaszlo.org/openlaszlo/patches/20071020-bargull-2.tar</a><br><br><br></blockquote></div><br><br clear="all"><br>--
<br>Henry Minsky<br>Software Architect<br><a href="mailto:hminsky@laszlosystems.com">hminsky@laszlosystems.com</a><br><br>