<html>
<body>
Approved. I tested on trunk.<br><br>
Before checking in, check with Amy. This change adds a new public
attribute. Perhaps this should be a private attribute.<br><br>
<br>
<blockquote type=cite class=cite cite="">Change 20070814-jcrowley-T by
<a href="mailto:jcrowley@doctormanhattan.mshome.net">
jcrowley@doctormanhattan.mshome.net</a> on<br>
2007-08-14 22:05:58 EDT<br>
in
/Users/jcrowley/src/svn/openlaszlo/legals-b<br>
for
<a href="http://svn.openlaszlo.org/openlaszlo/branches/legals">
http://svn.openlaszlo.org/openlaszlo/branches/legals</a><br>
<br>
Summary: long comobox does not render properly on firefox 2.0<br>
<br>
New Features:<br>
<br>
Bugs Fixed: LPP-4192<br>
<br>
Technical Reviewer: pbr<br>
QA Reviewer: henry<br>
Doc Reviewer:<br>
<br>
Documentation:<br>
<br>
Release Notes:<br>
<br>
Details: This one wasn't really that much of a bug, since<br>
you can set limits on the list size and
give it<br>
a scrollbar if you have to clip it, but I
thought<br>
there should still be some kind of check
to make<br>
sure it's not longer than the
canvas. I added<br>
attribute 'sizetocanvas', default true, to
set<br>
the number of visible elements in an
expanded<br>
list to fit the list on the canvas.
In the likely<br>
rare event one wants to let the list spill
off the<br>
canvas, they can always set sizetocanvas
to false.<br>
<br>
Tests: Run:<br>
<br>
<canvas><br>
<combobox id="serviceCombo"<br>
width="130"<br>
defaulttext="choose one..." editable="false"
<br>
enabled="true"><br>
<textlistitem
datapath="services:/services/service" <br>
text="$path{'@name'}"<br>
value="$path{'@value'}"/><br>
</combobox><br>
<dataset name="services"><br>
<services><br>
<service name="adamsboswe"
value="adamsboswe"/><br>
<service name="323iactive"
value="323iactive"/><br>
<service name="aecom" value="aecom"/><br>
<service name="1stomni" value="1stomni"/><br>
<service name="acisol" value="acisol"/><br>
<service name="ares" value="ares"/><br>
<service name="180solutio"
value="180solutio"/><br>
<service name="ameris" value="ameris"/><br>
<service name="11below" value="11below"/><br>
<service name="advcommerc"
value="advcommerc"/><br>
<service name="alloy" value="alloy"/><br>
<service name="abnerherrm"
value="abnerherrm"/><br>
<service name="active" value="active"/><br>
<service name="activewind"
value="activewind"/><br>
<service name="aei" value="aei"/><br>
<service name="adelante"
value="adelante"/><br>
<service name="3spn" value="3spn"/><br>
<service name="ampere" value="ampere"/><br>
<service name="abundant"
value="abundant"/><br>
<service name="advantage"
value="advantage"/><br>
<service name="aethionsi"
value="aethionsi"/><br>
<service name="altrec" value="altrec"/><br>
<service name="arin" value="arin"/><br>
<service name="aplia" value="aplia"/><br>
<service name="ailiant" value="ailiant"/><br>
<service name="about" value="about"/><br>
<service name="amerisec"
value="amerisec"/><br>
<service name="alorica" value="alorica"/><br>
<service name="americasho"
value="americasho"/><br>
<service name="americanap"
value="americanap"/><br>
<service name="anomaly" value="anomaly"/><br>
<service name="anyware" value="anyware"/><br>
<service name="aloricaden"
value="aloricaden"/><br>
<service name="appdiscove"
value="appdiscove"/><br>
<service name="alpaul" value="alpaul"/><br>
<service name="advpersonn"
value="advpersonn"/><br>
<service name="accesscomm"
value="accesscomm"/><br>
<service name="absclothin"
value="absclothin"/><br>
<service name="ainet" value="ainet"/><br>
<service name="aismedia"
value="aismedia"/><br>
<service name="americom"
value="americom"/><br>
<service name="accessline"
value="accessline"/><br>
<service name="altntech"
value="altntech"/><br>
<service name="apex" value="apex"/><br>
<service name="adinfuse"
value="adinfuse"/><br>
<service name="actsgroup"
value="actsgroup"/><br>
<service name="alliance"
value="alliance"/><br>
<service name="alphazeta"
value="alphazeta"/><br>
<service name="akamai" value="akamai"/><br>
<service name="aitcc" value="aitcc"/><br>
<service name="accellion"
value="accellion"/><br>
<service name="accor" value="accor"/><br>
<service name="agile" value="agile"/><br>
<service name="alta" value="alta"/><br>
<service name="apptrix" value="apptrix"/><br>
<service name="arcap" value="arcap"/><br>
<service name="addante" value="addante"/><br>
<service name="3amlabs" value="3amlabs"/><br>
<service name="altadisusa"
value="altadisusa"/><br>
<service name="amgen" value="amgen"/><br>
<service name="SJC-Lab" value="SJC-Lab"/><br>
<service name="accel" value="accel"/><br>
<service name="americanto"
value="americanto"/><br>
<service name="apple" value="apple"/><br>
<service name="aci" value="aci"/><br>
<service name="accipiter"
value="accipiter"/><br>
<service name="adpinvest"
value="adpinvest"/><br>
<service name="acsonline"
value="acsonline"/><br>
<service name="1ix" value="1ix"/><br>
<service name="aas" value="aas"/><br>
<service name="altoh" value="altoh"/><br>
<service name="adaptivepa"
value="adaptivepa"/><br>
<service name="abs" value="abs"/><br>
<service name="aim2game"
value="aim2game"/><br>
<service name="areatech"
value="areatech"/><br>
<service name="appiq" value="appiq"/><br>
<service name="advancedac"
value="advancedac"/><br>
<service name="1stfinanci"
value="1stfinanci"/><br>
<service name="aig" value="aig"/><br>
<service name="800one" value="800one"/><br>
<service name="aptela" value="aptela"/><br>
<service name="activegrou"
value="activegrou"/><br>
<service name="apress" value="apress"/><br>
<service name="3eco" value="3eco"/><br>
<service name="allrecipes"
value="allrecipes"/><br>
<service name="amselect"
value="amselect"/><br>
<service name="alpine" value="alpine"/><br>
<service name="argis" value="argis"/><br>
<service name="3dblinds"
value="3dblinds"/><br>
<service name="ardennes"
value="ardennes"/><br>
<service name="003realty"
value="003realty"/><br>
<service name="amgenuk" value="amgenuk"/><br>
<service name="adaptec" value="adaptec"/><br>
<service name="aonwarrant"
value="aonwarrant"/><br>
<service name="adpark" value="adpark"/><br>
<service name="apartment"
value="apartment"/><br>
<service name="arenaone"
value="arenaone"/><br>
<service name="adchemy" value="adchemy"/><br>
<service name="2wire" value="2wire"/><br>
<service name="advancecab"
value="advancecab"/><br>
</services><br>
</dataset><br>
</canvas><br>
<br>
In both modified and unmodified branches. Note that in unmodified,
it spills off into forever. In modified, it stops just before, and
there's a scrollbar. (If one explicitly sets the number of visible
elements, it'll override this.)<br>
<br>
Files:<br>
M lps/components/base/basecombobox.lzx<br>
<br>
Changeset:
<a href="http://svn.openlaszlo.org/openlaszlo/patches/20070814-">
http://svn.openlaszlo.org/openlaszlo/patches/20070814-</a><br>
jcrowley-T.tar</blockquote></body>
</html>