Maybe you got the wrong patch, lemme send again.<br><br>The change is just two lines, I changed the check that was<br><br>- if (!('height' in args) || (args.height == null)) {<br><br>to instead be <br>+ if (!this.hassetheight) {
<br><br>LzView has already computed hassetheight, and that computation factors in if there is a constraint on height, which the simple "!('height' in args) || (args.height == null))" test did not do. <br>
<br><br><br>===================================================================<br>--- LzText.lzs (revision 5701)<br>+++ LzText.lzs (working copy)<br>@@ -233,7 +233,7 @@<br> // if single line, use font line height
<br> // else get height from flash textobject.textHeight <br> // <br>- if (!('height' in args) || (args.height == null)) {<br>+ if (!this.hassetheight) {<br> this.sizeToHeight = true;<br> } else {
<br> this.setHeight(args.height);<br>@@ -381,7 +381,6 @@<br> // recalculate height<br> if (this.sizeToHeight) {<br> var h = this.sprite.getTextfieldHeight();<br>- //Debug.write('LzText.setText
computed height', h, this.sprite);<br> if (h > 0) {<br> this.setHeight(h);<br> }<br>@@ -659,7 +658,6 @@<br> //resizable fields adjust their height<br> if (this.sizeToHeight) {<br>
var h = this.sprite.getTextfieldHeight();<br>- //Debug.write('LzText.setText computed height', h, this.sprite);<br> if (h > 0) {<br> this.setHeight(h);<br> }<br><br><br>
<div><span class="gmail_quote">On 7/19/07, <b class="gmail_sendername">P T Withington</b> <<a href="mailto:ptw@openlaszlo.org">ptw@openlaszlo.org</a>> wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Can you explain this change? I would have thought the<br>super.construct would have already correctly compute hassetheight<br>from args. Why are you having to recompute it from scratch here?<br><br>On 2007-07-19, at 15:30 EDT, Henry Minsky wrote:
<br><br>> Change 20070719-hqm-6 by hqm@IBM-2E06404CB67 on 2007-07-19 15:26:44<br>> EDT<br>> in /cygdrive/c/users/hqm/openlaszlo/legals3/WEB-INF/lps/lfc<br>> for <a href="http://svn.openlaszlo.org/openlaszlo/branches/legals/WEB-INF/">
http://svn.openlaszlo.org/openlaszlo/branches/legals/WEB-INF/</a><br>> lps/lfc<br>><br>> Summary: fix for text sizing in DHTML<br>><br>> New Features:<br>><br>> Bugs Fixed: LPP-4248<br>><br>> Technical Reviewer: max (pending)
<br>> QA Reviewer: (pending)<br>> Doc Reviewer: (pending)<br>><br>> Documentation:<br>><br>> Release Notes:<br>><br>> Details:<br>><br>><br>> Multiline text should not try to resize it's height automatically
<br>> if there<br>> are<br>> any constraints on it's height (or if it's height is set to a<br>> constant)<br>><br>> Tests:<br>><br>> test case in bug report<br>><br>> Files:<br>> M views/LzText.lzs
<br>><br>><br>> Changeset: <a href="http://svn.openlaszlo.org/openlaszlo/patches/20070719-">http://svn.openlaszlo.org/openlaszlo/patches/20070719-</a><br>> hqm-6.tar<br>><br>> --<br>> Henry Minsky<br>
> Software Architect<br>> <a href="mailto:hminsky@laszlosystems.com">hminsky@laszlosystems.com</a><br><br></blockquote></div><br><br clear="all"><br>-- <br>Henry Minsky<br>Software Architect<br><a href="mailto:hminsky@laszlosystems.com">
hminsky@laszlosystems.com</a><br><br>