[Laszlo-dev] Using LZX in the LFC [Was: For Review: Change 20090921-maxcarlson-h Summary: UPDATED: Update look of context menu]

[Max Carlson]

That would be nice, but I don't think it's a high priority.  I used LZX 
mostly because it's much faster to iterate with it - there's no 
command-line, just edit the file and refresh the browser!

That said, it might be useful to have a compiler flag that doesn't emit 
the Canvas init preamble or initDone() after, so compiled LZX can work 
better as an include...

P T Withington wrote:
> Coming late to the review party:
> 
> It's interesting (and apropos of our discussion this morning) that you 
> found it easier to write contextmenu in LZX than in script.  Maybe we 
> should make this easier to do?  Rather than you having to provide a 
> recipe in contextmenu.lzx for how to build contextmenu.js, could we 
> extend the LFC compiler to just do the right thing if you include an LZX 
> file?
> 
> 
> On 2009-09-21, at 23:48, Max Carlson wrote:
> 
>> Change 20090921-maxcarlson-h by maxcarlson at bank.lan on 2009-09-21
>> 19:00:12 PDT
>>    in /Users/maxcarlson/openlaszlo/trunk-clean
>>    for http://svn.openlaszlo.org/openlaszlo/trunk
>>
>> Summary: UPDATED: Update look of context menu
>>
>> Bugs Fixed: LPP-8286 - DHTML: Improve look of context menu
>>
>> Technical Reviewer:ptw
>> QA Reviewer: hminsky
>>
>> Details: Updated to fix layout of items and correct the issue Henry
>> was seeing.
>>
>> LzContextMenuKernel - Use lz.lzcontextmenu class to handle display of
>> context menu - see contextmenu.js/lzx.
>>
>> LzSprite - Remove unused styles
>>
>> LzMouseKernel - contextmenu.js now handles hiding when the mouse goes
>> down outside itself.
>>
>> contextmenu.js - compiled version of contextmenu.lzx with canvas
>> constructor/preamble and canvas.initDone() removed.
>>
>> contextmenu.lzx - source lzx for contextmenu.js
>>
>> LaszloLibrary - Add contextmenu.js include for DHTML.  Must be
>> declared late because the context menu relies on the LFC
>>
>> Tests: context menus work as before, but they're prettier now!  Also
>> see test/contextmenu/api.lzx?lzr=dhtml
>>
>> Files:
>> M       WEB-INF/lps/lfc/kernel/dhtml/LzContextMenuKernel.lzs
>> M       WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
>> M       WEB-INF/lps/lfc/kernel/dhtml/LzMouseKernel.js
>> A       WEB-INF/lps/lfc/contextmenu.js
>> A       WEB-INF/lps/lfc/contextmenu.lzx
>> M       WEB-INF/lps/lfc/LaszloLibrary.lzs
>>
>> Changeset: 
>> http://svn.openlaszlo.org/openlaszlo/patches/20090921-maxcarlson-h.tar
>> _______________________________________________
>> Laszlo-reviews mailing list
>> Laszlo-reviews at www.openlaszlo.org
>> http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
> 

-- 
Regards,
Max Carlson
OpenLaszlo.org