[Laszlo-dev] For Review: Change 20090531-sallen-T Summary: LPP-8237 When an rtmpconnection is named, it is never used as the default connection

[Sarah Allen]

Raju,

Can you take a quick look at this fix?  It is a simple logic error  
that as been in the code for years.  I ran into, wrote a test file and  
fixed it.  Max is not usually up this early and thought you might be  
checking email in the evening in your time.

Thanks in advance,
Sarah

Change 20090531-sallen-T by sallen at sallen-mac.local on 2009-05-31  
09:31:16 PDT
     in /Users/sarah/src/svn/openlaszlo/trunk-bugfix
     for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: LPP-8237 When an rtmpconnection is named, it is never used as  
the default connection

New Features: n/a

Bugs Fixed:
LPP-8237 When an rtmpconnection is named, it is never used as the  
default connection

Technical Reviewer: (pending)
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation: now the behavior matches the docs

Release Notes:

Details:


Tests:
Test file checked in: trunk/test/video/test-rtmp-default.lzx
  Expected: click the button, status light should turn green
  Before the fix: the following warnings are reported in the debugger  
on app startup
WARNING @av/rtmpstatus.lzx#33: reference to undefined property  
'_default'
WARNING @test-rtmp-default.lzx#18: rtmpconnection not found for / 
view[2]/rtmpstatus
When you click the button, it stays red, even though the status text  
says "connected"
  Description
     As documented, the a/v extensions and components use the first  
rtmpconnection that is created if there is none specified for the  
component; however, if a rtmpconnection has a name, it is never used  
as the default Test file checked in: trunk/test/video/test-rtmp- 
default.lzx Expected: click the button, status light should turn green  
Results: the following warnings are reported in the debugger on app  
startup WARNING @av/rtmpstatus.lzx#33: reference to undefined property  
'_default' WARNING @test-rtmp-default.lzx#18: rtmpconnection not found  
for /view[2]/rtmpstatus When you click the button, it stays red, even  
though the status text says "connected"

Files:
M      lps/components/extensions/av/rtmpconnection.lzx

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20090531-sallen-T.tar


http://www.ultrasaurus.com