[Laszlo-dev] For Review: Change 20090519-bargull-2Mz Summary: DHTML: contextmenu part two

[André Bargull]

Change 20090519-bargull-2Mz by bargull at dell--p4--2-53 on 2009-05-19 19:41:02
in /home/Admin/src/svn/openlaszlo/trunk
for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: DHTML: contextmenu part two

New Features:

Bugs Fixed: LPP-8189 (Right click fires an erroneous mousedown and 
mouseup in DHTML) (partial)

Technical Reviewer: max
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:
LzSprite:
- canceling event-bubbling for all mouse-events => this was already done 
for all browsers (except Firefox) and all events (except onmouseup). Why 
wasn't Firefox affected? => All other browsers set "event.keyCode" to 
'0' for mouse-events, only Firefox sets "keyCode" to 'undefined'. Now 
take a look at "LzKeyboardKernel.__keyboardEvent()", every event was 
canceled in that function if "keyCode" was '>= 0'!

LzKeyboardKernel:
- move handling for control keys (ctrl, shift, alt) into separate 
function. It should be obvious why having a single function for both, 
mouse-events and keyboard-events, is a bad idea (see keyCode issue from 
above).


Tests:

Files:
M WEB-INF/lps/lfc/kernel/dhtml/LzKeyboardKernel.js
M WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
M WEB-INF/lps/lfc/kernel/dhtml/LzMouseKernel.js

Changeset: 
http://svn.openlaszlo.org/openlaszlo/patches/20090519-bargull-2Mz.tar