[Laszlo-dev] For Review: Change 20090515-maxcarlson-Y Summary: Make context menu events more consistent with Flash on Windows

André Bargull andre.bargull at udo.edu
Sat May 16 08:59:58 PDT 2009


It's still broken in Firefox for me:
- clicking a disabled contextmenu item closes contextmenu
- also clicking somewhere on the contextmenu, but not on an item, closes 
the contextmenu
And some other issues, I can't remember yet what exactly..
Nevertheless, I've sent you another changeset which should cover all 
issues left.


On 5/16/2009 1:09 AM, Max Carlson wrote:
> Change 20090515-maxcarlson-Y by maxcarlson at Bank on 2009-05-15 15:52:07 PDT
>     in 
> /Users/maxcarlson/openlaszlo/trunk-clean/WEB-INF/lps/lfc/kernel/dhtml
>     for 
> http://svn.openlaszlo.org/openlaszlo/trunk/WEB-INF/lps/lfc/kernel/dhtml
> 
> Summary: Make context menu events more consistent with Flash on Windows
> 
> Bugs Fixed: LPP-8189 - Right click fires an erroneous mousedown and 
> mouseup in DHTML.
> 
> Technical Reviewer: andre.bargull at udo.edu
> QA Reviewer: mdemmon
> 
> Details: LzContextMenuKernel - Add flag to prevent sending onmenuopen 
> event more than once.  Cancel event bubbling for onclick, onmousedown 
> and onmouseup events to fix:
> Issues in DHTML (IE):
> ---
> - selecting an enabled context-menu item gives global mouse-events:
> DEBUG: global onmousedown
> DEBUG: global onmouseup
> DEBUG: global onclick
> 
> - selecting a disabled item closes the context-menu
> ---
> 
> Issues in DHTML (FF3, Saf3):
> ---
> - selecting an enabled context-menu item fires global mouseup-event:
> DEBUG: global onmouseup
> 
> LzMouseKernel - Change event sending code to prevent sending global 
> onclick events and hide context menus when any onclick event is received.
> 
> Tests: Issues in IE, Firefox and Safari are now fixed.  Updated testcase 
> from LPP-8189 ran with lzt=testboth (lpp-8189.lzx?lzt=testboth) shows 
> consistent behavior across windows swf and dhtml.
> 
> Files:
> M      WEB-INF/lps/lfc/kernel/dhtml/LzContextMenuKernel.lzs
> M      WEB-INF/lps/lfc/kernel/dhtml/LzMouseKernel.js
> 
> Changeset: 
> http://svn.openlaszlo.org/openlaszlo/patches/20090515-maxcarlson-Y.tar
> 


More information about the Laszlo-dev mailing list