[Laszlo-dev] For Review: Change 20090511-bargull-T7M Summary: fix position-cache bug in LzSprite

[Max Carlson]

Good catch - approved!

André Bargull wrote:
> Change 20090511-bargull-T7M by bargull at dell--p4--2-53 on 2009-05-11 
> 01:19:06
> in /home/Admin/src/svn/openlaszlo/trunk
> for http://svn.openlaszlo.org/openlaszlo/trunk
> 
> Summary: fix position-cache bug in LzSprite
> 
> New Features:
> 
> Bugs Fixed: LPP-8163 (DHTML: cannot select items in combobox), LPP-8168 
> (DHTML: scrollbar and drag oddness)
> 
> Technical Reviewer: max
> QA Reviewer: henry
> Doc Reviewer: (pending)
> 
> Documentation:
> 
> Release Notes:
> 
> Details:
> The simple poscachedirty flag meachanism doesn't work because:
> (1) if view "a" cached position, it's parent-view moves (this sets the 
> dirty-flag) and then a sibling view of "a" calls getMouse(), view "a" 
> will use the invalid cache (first additional testcase for LPP-8163)
> (2) if view "a" cached position, it moves (this sets the dirty-flag) and 
> then a subview calls getMouse(), view "a" will use the invalid cache 
> (second additional testcase for LPP-8163)
> 
> LPP-8163 and LPP-8168 are types of these general bugs.
> 
> So replace the flag with a cache-id to know when any parent has got 
> newer cache-information.
> 
> 
> Tests:
> see bugreport
> 
> Files:
> M WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
> 
> Changeset: 
> http://svn.openlaszlo.org/openlaszlo/patches/20090511-bargull-T7M.tar
> 

-- 
Regards,
Max Carlson
OpenLaszlo.org