[Laszlo-dev] For Review: Change 20090507-hqm-x Summary: fix for DHTML IE: Context menus too wide

P T Withington ptw at pobox.com
Fri May 8 10:34:51 PDT 2009


This (or something like it) is surely a better solution.  We really  
don't want to be using any HTML tags in our code, because there is no  
standard for the CSS attributes those tags will have.  If we _do_ use  
an HTML tag, we should use CSS to specify all the relevant attributes  
on the tag to prevent browser variations due to their implicit styles.

On 2009-05-08, at 13:21EDT, André Bargull wrote:

> The current change breaks the css-layout, doesn't it? Because the  
> css-selectors won't work anymore ("#lzcontextmenu a" resp.  
> "#lzcontextmenu a:hover", see "LzSprite.js").
>
> Another solution would be to use styled div-tags, like:
> <div class="separator"></div>
>
> With the proper layout:
> // Firefox
> #lzcontextmenu div.separator {
>    border-top: 1px solid #4b4b4b;
>    border-left: 1px solid #4b4b4b;
>    border-right: 1px solid #d3d3d3;
>    border-bottom: 1px solid #d3d3d3;
>    margin: 6px 0px;
> }
>
> // Safari
> #lzcontextmenu div.separator {
>    border-top: 1px solid #9a9a9a;
>    border-left: 1px solid #9a9a9a;
>    border-right: 1px solid #eeeeee;
>    border-bottom: 1px solid #eeeeee;
>    margin: 6px 0px;
> }
>
> // Opera
> #lzcontextmenu div.separator {
>    border-top: 1px solid #4c4c4c;
>    border-left: 1px solid #4c4c4c;
>    border-right: 1px solid #cccccc;
>    border-bottom: 1px solid #cccccc;
>    margin: 10px 0px;
> }
>
> // Internet Explorer
> #lzcontextmenu div.separator {
>    border-top: 1px solid #808080;
>    border-left: none;
>    border-right: none;
>    border-bottom: 1px solid #d4d0c8;
>    margin: 7px 0px;
> }
>
>
> On 5/7/2009 6:53 PM, Henry Minsky wrote:
>> Change 20090507-hqm-x by hqm at badtzmaru.home on 2009-05-07 12:51:20  
>> EDT
>>    in /Users/hqm/openlaszlo/trunk-diamond
>>    for http://svn.openlaszlo.org/openlaszlo/trunk
>> Summary: fix for  DHTML IE: Context menus too wide
>> New Features:
>> Bugs Fixed: LPP-8137
>> Technical Reviewer: max
>> QA Reviewer: andre
>> Doc Reviewer: (pending)
>> Documentation:
>> Release Notes:
>> Details:
>> + enclose DHTML context menu within a <table>, to prevent the <hr>  
>> from expanding to
>> the width of the canvas in IE7.
>> Tests:
>> tested in FF/OSX, and IE7/WINXP  DHTML
>> test/contextmenu/ie7.lzx
>> Files:
>> A      test/contextmenu/ie7.lzx
>> M      WEB-INF/lps/lfc/kernel/dhtml/LzContextMenuKernel.lzs
>> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20090507-hqm-x.tar




More information about the Laszlo-dev mailing list