[Laszlo-dev] For Review: Change 20090506-hqm-N Summary: fix for setting resource frame number from lzx tag in swf9

[André Bargull]

Approved.

I don't think you don't need to change that line, otherwise "this.frame" 
may be assigned to a value greater than "frames.length" (which is not 
valid).


On 5/6/2009 5:36 PM, Henry Minsky wrote:
> Question about this, there is a line 1094, just below this change that I 
> am wondering if it also needs to be changed from
> 
>             } else {
>                     // Set later, to prevent movieclip resources from 
> being forced to frame 1 - see LPP-7534
>                     this.frame = fn;
> 
> to
> 
>             } else {
>                     // Set later, to prevent movieclip resources from 
> being forced to frame 1 - see LPP-7534
>                     this.frame = origfn;
> 
> ?
> 
> 
> 
> Change 20090506-hqm-N by hqm at badtzmaru.home on 2009-05-06 11:32:47 EDT
>     in /Users/hqm/openlaszlo/trunk4
>     for http://svn.openlaszlo.org/openlaszlo/trunk
> 
> Summary: fix for setting resource frame number from lzx tag in swf9
> 
> New Features:
> 
> Bugs Fixed: LPP-8161
> 
> Technical Reviewer: max
> QA Reviewer: andre
> Doc Reviewer: (pending)
> 
> Documentation:
> 
> Release Notes:
> 
> Details:
> 
> + Call this.loaderMC.gotoAndStop() with the actual desired frame number, 
> not the one which has
> been munged.
> 
> 
> Tests:
> 
> test case from bug report
> 
> Files:
> M      WEB-INF/lps/lfc/kernel/swf9/LzSprite.as
> 
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20090506-hqm-N.tar
>