[Laszlo-dev] For Review: Change 20090428-maxcarlson-7 Summary: Updated: Add support for resource tiling to swf and dhtml runtimes

[André Bargull]

LzSprite (swf8):
- The tiling-bitmap isn't disposed when tiling is set to false.
- Do you need to dispose the tiling-bitmap on destroy?
- Q: Why do you need to call updateTiling() for stop()?

LzView:
- Why do you install a default argument for the tiling setter?

LzSprite (dhtml):
- setting "tiling" to false sends on "onload"-event, it doesn't get send 
in swf8

Still open from last review:
DHTML:
> - There is currently no support for reporting image loading failures. In fact there is even an 'onload' event although the image-url was invalid. 

And:
> General Question: Don't we also want to support repeat/tiling on a specific axis instead of just repeat-both?



On 4/28/2009 11:37 PM, Max Carlson wrote:
> Change 20090428-maxcarlson-7 by maxcarlson at Bank on 2009-04-28 14:33:57 PDT
>     in /Users/maxcarlson/openlaszlo/trunk-clean
>     for http://svn.openlaszlo.org/openlaszlo/trunk
> 
> Summary: Updated: Add support for resource tiling to swf and dhtml runtimes
> 
> New Features: Views now support a 'tiling' attribute.  Tiling and 
> stretches can't be set at the same time.
> 
> Bugs Fixed: LPP-7714 - Components: DHTML implementation for tiling, 
> LPP-7715 - Components: Tiling - bitmap fill support (partial)
> 
> Technical Reviewer: andre.bargull at udo.edu
> QA Reviewer: hminsky
> 
> Details: Updated to address Andre's concerns
> 
> swf/LzSprite.as - Add tiling capability, set to true.  If tiling, update 
> on setWidth(), setHeight() and stop().  Add implementation of 
> setTiling() to be called by view.
> 
> dhtml/LzSprite.js - Add tiling capability, set to true.  Refactor img 
> tag creating logic to shared method.  Add tiling setup to setSource().  
> If tiling, update on setWidth(), setHeight() and frame updates.  Add 
> implementation of setTiling() to be called by view.
> 
> swf9/LzSprite.as -  Add tiling capability, set to false.
> 
> LaszloView.lzs - Call tiling setter from init method to guarantee it 
> runs before resources are set.  Add warning to stretches setter and turn 
> off tiling if tiling is on.  Add tiling property, setter which calls 
> sprites - warn if stretches is on, and turn off when setting tiling == 
> true.
> 
> Tests: See LPP-7714 for a testcase which should work in DHTML and swf.
> 
> Files:
> M      WEB-INF/lps/lfc/kernel/swf/LzSprite.as
> M      WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
> M      WEB-INF/lps/lfc/kernel/swf9/LzSprite.as
> M      WEB-INF/lps/lfc/views/LaszloView.lzs
> 
> Changeset: 
> http://svn.openlaszlo.org/openlaszlo/patches/20090428-maxcarlson-7.tar
>