[Laszlo-dev] For Review: Change 20090501-maxcarlson-G Summary: IE-specific cleanup of text size div leak prevention code
P T Withington
ptw at laszlosystems.com
Sat May 2 06:00:55 PDT 2009
Change your iteration over the array to be `for (var i = 0...` instead
of `for in` and I approve. Iterating over arrays with `for in` is
"considered harmful".
On 2009-05-01, at 21:38EDT, Max Carlson wrote:
> Change 20090501-maxcarlson-G by maxcarlson at Bank on 2009-05-01
> 18:32:10 PDT
> in /Users/maxcarlson/openlaszlo/trunk-clean
> for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: IE-specific cleanup of text size div leak prevention code
>
> Bugs Fixed: LPP-8016 - Performance differences between OL 4.0.x and
> 4.3.x
>
> Technical Reviewer: ptw
> QA Reviewer: hminsky
>
> Details: This was done to make ptw happier. It should be more
> efficient since IE likes arrays better than objects :)
>
> Tests: All apps run as before. IE 6 shows no leaks in the drip leak
> detector for webtop :)
>
> Files:
> M WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
> M WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js
>
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20090501-maxcarlson-G.tar
More information about the Laszlo-dev
mailing list