[Laszlo-dev] For Review: Change 20090430-maxcarlson-I Summary: Raise framerate during app initialization

[P T Withington]

Sounds to me like we should not make this change then.

On 2009-05-01, at 11:40EDT, Henry Minsky wrote:

> I tried an app with 5000 views, as tags inline, and I don't see any
> significant change reported by the inittimer before or after this  
> change.
>
>
> On Fri, May 1, 2009 at 10:43 AM, Henry Minsky <hminsky at laszlosystems.com 
> >wrote:
>
>> The calls to new won't be getting queued I believe. I'll try a test  
>> case
>> which just has lots of <view> tags inline.
>>
>>
>>
>> On Thu, Apr 30, 2009 at 10:15 PM, Max Carlson <max at openlaszlo.org>  
>> wrote:
>>
>>> Hmmm I can't seem to prove that makes any difference.  This is  
>>> probably
>>> because we're not doing instantiation across multiple frames - at  
>>> least this
>>> shows no change in swf9:
>>>
>>> <canvas>
>>>   <view id="foo">
>>>       <handler name="onconstruct">
>>>           for (var i = 0; 10000 > i; i++) {
>>>               new lz.view(this, {x:i, y:i, width:100, height: 100,
>>> bgcolor: 'red'});
>>>           }
>>>       </handler>
>>>   </view>
>>>   <inittimer/>
>>> </canvas>
>>>
>>>
>>>
>>> Max Carlson wrote:
>>>
>>>> Change 20090430-maxcarlson-I by maxcarlson at Bank on 2009-04-30  
>>>> 15:28:22
>>>> PDT
>>>>  in /Users/maxcarlson/openlaszlo/trunk-clean
>>>>  for http://svn.openlaszlo.org/openlaszlo/trunk
>>>>
>>>> Summary: Raise framerate during app initialization
>>>>
>>>> Bugs Fixed: LPP-8136 - Set the framerate to 1000 during app
>>>> initialization
>>>>
>>>> Technical Reviewer: ptw
>>>> QA Reviewer: hminsky
>>>>
>>>> Details: framerate setter caches any values during init, setting  
>>>> the
>>>> framerate to 1000.  init() sets the framerate back to the cached  
>>>> value.
>>>> Move onafterinit event sending to the end of init() so it can be  
>>>> used to
>>>> turn profiling back on.
>>>>
>>>> Tests: Startup should be slightly faster in DHTML and SWF9, where  
>>>> the
>>>> framerate can be set dynamically
>>>>
>>>> Files:
>>>> M      WEB-INF/lps/lfc/views/LaszloCanvas.lzs
>>>>
>>>> Changeset:
>>>> http://svn.openlaszlo.org/openlaszlo/patches/20090430-maxcarlson-I.tar
>>>>
>>>
>>> --
>>> Regards,
>>> Max Carlson
>>> OpenLaszlo.org
>>>
>>
>>
>>
>> --
>> Henry Minsky
>> Software Architect
>> hminsky at laszlosystems.com
>>
>>
>>
>
>
> -- 
> Henry Minsky
> Software Architect
> hminsky at laszlosystems.com