[Laszlo-dev] [REVISED^3] For Review: Change 20090213-ptw-X Summary: DHTML scrolling tweaks

[P T Withington]

[REVISED^3: I think this is _really_ close, I'd like to check it in so  
it can get exercised and follow up with tweaks if that's ok with the  
reviewer.]

Change 20090213-ptw-X by ptw at dueling-banjos.home on 2009-02-13  
21:32:09 EST
     in /Users/ptw/OpenLaszlo/trunk-4
     for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: DHTML scrolling tweaks

Bugs Fixed: LPP-6580 scrolledittext doesn't work in 4.1 (partial0

Technical Reviewer: max (Message-ID: <49A55D1C. 
5010007 at laszlosystems.com>)
QA Reviewer: hminsky (pending)

Details:
     LzSprite, LzTextSprite, LzInputTextSprite: note constructor for
     debugger, assign correct className's to divs

     LzSprite: better debugger printing of sprite, adjust
     default CSS to always create scrollbars for text elements (that
     will be clipped away), add a new quirk for scrollbar_width, create
     new container styles that are used to pad the text element to
     match where it would be positioned in swf, adjust lineHeight and
     letterSpacing of text elements to match swf

     LzTextSprite: Use lztextcontainer for div.  Changed getTextSize to
     getTextDimension, to _not_ include quirks, because it does not
     include the quirks in the cache key, so bad matches were being
     found in the cache, and to use correct class and style overrides
     to get accurate measurments.  It's clients apply quirks as
     necessary. Fixed getTextWidth, getTextHeight, getTextfieldHeight,
     to obey kernel API contract.

     LzTextSprite, LzInputTextSprite: correctly call super
     methods for setWidth, setHeight; arrange to hide scrollbars under
     clip

     LzInputTextSprite: Use lzinputtextcontainer for div.  Update div
     and clipcontainer styles for multiline.  Remove redundant
     getTextHeight and getTextfieldHeight methods.  Fix setMultiline to
     correctly copy styles to new div.

     LzDebug: note div style in debug name

     LzText, LzTextSprite: Use view height to adjust legacy attributes

     build-opt: Missing dependency noticed in passing

     scrolledittext: Correct math error

     scrolledittext-test: Spiff up diagnostic info

Tests:
     test/lfc/legals/keyboardandmouse.lzx?lzr=dhtml&debug=true
     (scrolling left and right)
     demos/lzpix/app.lzx?lzt=html&lzr=dhtml
     examples/components/edittext_example.lzx?lzt=testboth
     lps/components/incubator/test/scrolledittext-test.lzx?lzt=testboth

Files:
M      WEB-INF/lps/lfc/kernel/swf/LzTextSprite.as
M      WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
M      WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js
M      WEB-INF/lps/lfc/kernel/dhtml/LzInputTextSprite.js
M      WEB-INF/lps/lfc/kernel/swf9/LzTextSprite.as
M      WEB-INF/lps/lfc/debugger/platform/dhtml/LzDebug.js
M      WEB-INF/lps/lfc/views/LzText.lzs
M      build-tools/build-opt.xml
M      lps/components/incubator/scrolledittext.lzx
M      lps/components/incubator/test/scrolledittext-test.lzx

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20090213-ptw-X.tar