[Laszlo-dev] [JIRA] Updated: (LPP-7551) several text-link issues

[P T Withington]

We need to sort this out.

If 7840 is for 4.2.0.3, then I suggest we re-open that and Henry  
create the minimal fix (independently) for that.  My assessment is  
that the fix for 7551 is too large, complex, and risky to be migrated  
to 4.2.0.3.

On 2009-03-18, at 21:26EDT, Amy Muntz wrote:

> Wait a minute....
>
> LPP-7551 was the bug that remained when we closed LPP-7840 as a dup  
> of it.
> LPP-7840 is a p0 for 4.2.  Henry fixed part of the problem initially  
> in trunk,
> and that fix was merged to 4.2. However, the second fix that Henry  
> made only
> appears in trunk. It also needs to be merged to the 4.2 branch.
>
> This is independent of 4.2.1.
>
> -- -Amy
>
>
> On Wed, Mar 18, 2009 at 5:51 PM , P T Withington wrote:
>
>> Right. Then there is no merge issue. 4.2.1 will be a new branch  
>> from trunk. I should have named 4.2 4.2.0 to make this clearer.
>>
>> We should only be addressing P0 4.2.1 bugs in trunk now, as we wind  
>> close to creating its branch.
>>
>> And we ought to be thinking about no more point releases for 4.2.0,  
>> with 4.2.1 about to be available.
>>
>> On Mar 18, 2009, at 17:18, Henry Minsky <henry.minsky at gmail.com>  
>> wrote:
>>
>>> This was all work done in trunk, as far as I know. We did a big
>>> workaround for mouse events in swf9 because
>>> in order to make hyperlinks work in the flash TextField object, you
>>> have to set mouseEnabled=true, which caused many of the other mouse
>>> behaviors to break.  So we have all this hair which grabs the mouse
>>> events
>>> and then dispatches them to the 'correct' views, where 'correct'  
>>> means
>>> the swf8 behavior.
>>>
>>>
>>>
>>> On Wed, Mar 18, 2009 at 5:02 PM, P T Withington <ptw at pobox.com>  
>>> wrote:
>>>> I'm confused. Where was this change made originally?
>>>>
>>>> On Mar 18, 2009, at 16:11, Henry Minsky  
>>>> <hminsky at laszlosystems.com> wrote:
>>>>
>>>>> There were a lot of changes to the mouse and text  kernel  that  
>>>>> went
>>>>> along with this change, I'm not sure if we want to bring all  
>>>>> that to
>>>>> the 4.2 branch.
>>>>>
>>>>>
>>>>>
>>>>> On Wed, Mar 18, 2009 at 12:21 PM, Amy Muntz (JIRA)
>>>>> <jira at laszlosystems.com> wrote:
>>>>>>
>>>>>>   [
>>>>>>
>>>>>> http://www.openlaszlo.org/jira/browse/LPP-7551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel 
>>>>>>  ]
>>>>>>
>>>>>> Amy Muntz updated LPP-7551:
>>>>>> ---------------------------
>>>>>>
>>>>>>  Fix Version/s: 4.2.0.3
>>>>>>
>>>>>> Please make sure this is also merged to the 4.2 branch as well.  
>>>>>> Also, the
>>>>>> preference is that the attribute be enabled by default to match  
>>>>>> the swf8
>>>>>> behavior.
>>>>>>
>>>>>>> several text-link issues
>>>>>>> ------------------------
>>>>>>>
>>>>>>>               Key: LPP-7551
>>>>>>>               URL: http://www.openlaszlo.org/jira/browse/ 
>>>>>>> LPP-7551
>>>>>>>           Project: OpenLaszlo
>>>>>>>        Issue Type: Bug
>>>>>>>        Components: LFC - Text
>>>>>>>  Affects Versions: MisterDonut (4.2 Final)
>>>>>>>          Reporter: André Bargull
>>>>>>>          Assignee: Henry Minsky
>>>>>>>          Priority: P0
>>>>>>>           Fix For: 4.2.0.3, 4.2.1
>>>>>>>
>>>>>>>       Attachments: lpp-7551.lzx, LPP-7551.tar
>>>>>>>
>>>>>>>
>>>>>>> 1) text-links don't work in swf9/swf10 without calling kernel  
>>>>>>> methods
>>>>>>> ("enableClickableLinks") and updating the textfield's  
>>>>>>> mouseEnabled property
>>>>>>> 2) the documentation for LzText#makeTextLink is not complete,  
>>>>>>> only the
>>>>>>> first line is shown (see
>>>>>>>
>>>>>>> "http://openlaszlo.org/lps4.2/docs/reference/lz.text.html#LzText.prototype.makeTextLink 
>>>>>>>  "
>>>>>>> and compare with sources)
>>>>>>> 3) swf8-10 change the cursor to a handpointer as soon as the  
>>>>>>> mouse is
>>>>>>> over a link. This doesn't happen in dhtml.
>>>>>>> testcase:
>>>>>>> ---
>>>>>>> <canvas debug="true">
>>>>>>> <text multiline="true" width="150" >
>>>>>>>   <handler name="oninit" >
>>>>>>>     if ($as3) {
>>>>>>>       this.sprite.textfield.mouseEnabled = true;
>>>>>>>       this.sprite.enableClickableLinks(true);
>>>>>>>     }
>>>>>>>     this.format("click %s or %s", this.makeTextLink("here",  
>>>>>>> "opt1"),
>>>>>>> this.makeTextLink("here", "opt2"));
>>>>>>>   </handler>
>>>>>>>   <handler name="ontextlink" args="val" >
>>>>>>>     this.addFormat("\noption %d was clicked", val == "opt1" ?   
>>>>>>> 1 : 2);
>>>>>>>   </handler>
>>>>>>> </text>
>>>>>>> </canvas>
>>>>>>> ---
>>>>>>
>>>>>> --
>>>>>> This message is automatically generated by JIRA.
>>>>>> -
>>>>>> If you think it was sent incorrectly contact one of the  
>>>>>> administrators:
>>>>>> http://www.openlaszlo.org/jira/secure/Administrators.jspa
>>>>>> -
>>>>>> For more information on JIRA, see: http://www.atlassian.com/software/jira
>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Henry Minsky
>>>>> Software Architect
>>>>> hminsky at laszlosystems.com
>>>>>
>>>>
>>>
>>>
>>>
>>> -- 
>>> Henry Minsky
>>> Software Architect
>>> hminsky at laszlosystems.com