[Laszlo-dev] For Review: Change 20090309-Philip-8 Summary: Fix IE/DHTML when specifying +/- Infinity

[André Bargull]

The NaN conversion doesn't match exactly swf8/swf9.

I've added two additional tests to the testcase:
---
<button x="15" y="100" text="x: -> 100 -> NaN" 
onclick="v4.setAttribute('x', 100);v4.setAttribute('x', NaN)" />
<button x="145" y="100" text="width: -> 100 -> NaN" 
onclick="v4.setAttribute('width', 100);v4.setAttribute('width', NaN)" />
---
These are the results after clicking on both buttons:
SWF8: v4 -> x=100, width=100
SWF9: v4 -> x=0, width=100
DHTML: v4 -> x=0, width=0

Btw, the green view, v4, is placed at different positions when you 
compare swf8-debug (0,0) and swf8-nondebug (50,50), most likely the same 
issue as in LPP-7885.

Otherwise approved!


On 3/9/2009 9:05 PM, Philip Romanik wrote:
> Change 20090309-Philip-8 by Philip at Philip-DC <mailto:Philip at Philip-DC> 
> on 2009-03-09 15:45:16 EDT
>     in /cygdrive/f/laszlo/svn/src/svn/openlaszlo/trunk
>     for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: Fix IE/DHTML when specifying +/- Infinity
>
> New Features:
>
> Bugs Fixed: LPP-7860
>
> Technical Reviewer: ptw
> QA Reviewer: andre
> Doc Reviewer: (pending)
>
> Documentation:
>
> Release Notes:
>
> Details:
> As discussed in the bug report I modified CSSDimension to transform 
> +/- Infinity into the the largest/smallest possible values. NaN is 
> transformed into 0.
>
> I removed the isNaN checks in setX, setY, setWidth, setHeight so the 
> dhtml runtime is consistent with swf/swf9. These methods call 
> CSSDimension so NaN is converted to 0.
>
> Tests:
> See the testcase I posted in jira. It produces the same output in all 
> runtimes, and runs without error in IE7.
>
> smokecheck, lzpix in dhtml.
>
> Files:
> M      WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
>
> Changeset: 
> http://svn.openlaszlo.org/openlaszlo/patches/20090309-Philip-8.tar