[Laszlo-dev] For Review: Change 20090305-maxcarlson-9 Summary: Make framerate dynamically adjustable

[Philip Romanik]

Approved!

There is no error checking so you are allowed to set the framerate to 
things like -1. It also means you will read back the framerate as -1. 
Setting the framerate to 0  works for dhtml/swf9, but runs at full 
speed in swf8.

I uploaded a modified testcase which verifies the event is sent.


>Change 20090305-maxcarlson-9 by 
><mailto:maxcarlson at Bank.lan>maxcarlson at Bank.lan on 2009-03-05
>06:55:14 PST
>      in /Users/maxcarlson/openlaszlo/trunk-clean
>      for 
> <http://svn.openlaszlo.org/openlaszlo/trunk>http://svn.openlaszlo.org/openlaszlo/trunk
>
>Summary: Make framerate dynamically adjustable
>
>Bugs Fixed: LPP-7866 - Make framerate adjustable via canvas.framerate
>
>Technical Reviewer: ptw
>QA Reviewer: promanik
>
>Details: swf9/LzIdleKernel - Replace startTimer() method with
>setFrameRate() implementation.
>
>LFCApplication - Register LzIdleKernel.__update() for frame events directly.
>
>kernel/LzIdleKernel - Add implementation of setFrameRate().
>
>LaszloCanvas - Set framerate to a default of 30, add setter and event.
>
>CanvasCompiler - Read framerate from canvas attribute.
>
>SWFWriter - Read and set framerate of the compiled swf from the canvas model.
>
>Canvas.java - Add framerate property, getter and setter.
>
>Tests: See LPP-7866.  In swf8, the physical frame rate will be set 
>based on the canvas value.
>
>Files:
>M      WEB-INF/lps/lfc/kernel/swf9/LzIdleKernel.as
>M      WEB-INF/lps/lfc/kernel/swf9/LFCApplication.as
>M      WEB-INF/lps/lfc/kernel/LzIdleKernel.lzs
>M      WEB-INF/lps/lfc/services/LzIdle.lzs
>M      WEB-INF/lps/lfc/views/LaszloCanvas.lzs
>M      WEB-INF/lps/server/src/org/openlaszlo/compiler/
>CanvasCompiler.java
>M      WEB-INF/lps/server/src/org/openlaszlo/compiler/SWFWriter.java
>M      WEB-INF/lps/server/src/org/openlaszlo/compiler/Canvas.java
>
>Changeset: 
><http://svn.openlaszlo.org/openlaszlo/patches/20090305-maxcarlson-9.tar>http://svn.openlaszlo.org/openlaszlo/patches/20090305-maxcarlson-9.tar
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.openlaszlo.org/pipermail/laszlo-dev/attachments/20090305/a908c1f3/attachment.html