[Laszlo-dev] For Review: Change 20090302-bargull-uSw Summary: some more tweaks for dhtml contextmenu / erroneous onmousemove-events

[Max Carlson]

Approved!

André Bargull wrote:
> Updated changeset to address Max' comments. While refactoring the code, 
> LPP-7852 (DHTML: text-events generate onmousemove) was found.
> 
> 
> Change 20090302-bargull-uSw by bargull at dell--p4--2-53 on 2009-03-02 
> 13:37:27
> in /home/Admin/src/svn/openlaszlo/trunk
> for http://svn.openlaszlo.org/openlaszlo/trunk
> 
> Summary: some more tweaks for dhtml contextmenu / erroneous 
> onmousemove-events
> 
> New Features:
> 
> Bugs Fixed: LPP-7661 (Views without bgcolor allow context menus to 
> receive clicks in SWF but not in DHTML), LPP-7852 (DHTML: text-events 
> generate onmousemove)
> 
> Technical Reviewer: max
> QA Reviewer: promanik
> Doc Reviewer: (pending)
> 
> Documentation:
> 
> Release Notes:
> 
> Details:
> IE doesn't implement pageX/pageY, only clientX/clientY. In order to get 
> the proper absolute x/y-values, scrollLeft/scrollTop needs to be added 
> (see http://www.quirksmode.org/js/events_properties.html#position).
> And I shouldn't try to be too smart in __showContextMenu() when using || 
> for short-circuit ops: Some browsers implement both pageX/pageY and 
> clientX/clientY, so that code did effectively a binary or.
> And "owner" property is not required (needed for LPP-7823 dhtml/IE). And 
> return from loop when elem is `null` which may happen for invalid 
> positions. And finally, also check tagName, this could be necessary 
> because "owner" is no longer required.
> 
> UPDATE:
> LzInputTextSprite:
> - register for onmousemove to detect mouse-movements
> - don't forward onmousemove-events to inputtextevent()
> 
> LzMouseKernel:
> - only forward 'onmousemove' for real mousemove-events (LPP-7852)
> 
> 
> Tests:
> IE pageX/pageY fix:
> - recompile developer console for dhtml
> - right click on dev console in dhtml/IE, note that contextmenu appears 
> at proper position
> 
> testcases for LPP-7852 (attached at bugreport)
> 
> Files:
> M WEB-INF/lps/lfc/kernel/dhtml/LzMouseKernel.js
> M WEB-INF/lps/lfc/kernel/dhtml/LzInputTextSprite.js
> 
> Changeset: 
> http://svn.openlaszlo.org/openlaszlo/patches/20090302-bargull-uSw.tar
> 

-- 
Regards,
Max Carlson
OpenLaszlo.org