[Laszlo-dev] For Review: Change 20090531-sallen-T Summary: LPP-8237 When an rtmpconnection is named, it is never used as the default connection

[Raju Bitter]

Correction, Sarah.  I just saw found a minor bug for SWF9 with that  
change: in TRUNK the lz.rtmpconnection.connections array had been  
instantiated within the attribute declaration. You are setting the  
value to "null", instead of "{}". That impacts the if-condition in  
line 120, where you'd have to check lz.rtmpconnection.connections !=  
null, e.g.

                 if (lz.rtmpconnection.connections != null &&  
lz.rtmpconnection.connections[this.name] != null) {

For SWF8 you won't see an error, but without that addition you'll get  
an exception in SWF9:
> TypeError: Error #1009: Cannot access a property or method of a null  
> object reference.
> 	at $lzc$class_rtmpconnection/init()[/Users/rajubitter/lib/jakarta- 
> tomcat-5.0.30/temp/lzswf9/Users/rajubitter/src/svn/openlaszlo/trunk- 
> sandbox/test/video/build/test-rtmp-default/$lzc 
> $class_rtmpconnection.as:25]
> 	at LzNode/__LZcallInit()[/private/tmp/lzswf9/lzgen7478/LzNode.as:490]
> 	at LzCanvas/__LZcallInit()[/private/tmp/lzswf9/lzgen7478/ 
> LzCanvas.as:493]
> 	at LzCanvas/__LZinstantiationDone()[/private/tmp/lzswf9/lzgen7478/ 
> LzCanvas.as:440]
> 	at LzInstantiatorService/makeSomeViews()[/private/tmp/lzswf9/ 
> lzgen7478/LzInstantiatorService.as:234]
> 	at LzInstantiatorService/checkQ()[/private/tmp/lzswf9/lzgen7478/ 
> LzInstantiatorService.as:171]
> 	at Function/http://adobe.com/AS3/2006/builtin::call()
> 	at LzEvent/sendEvent()[/private/tmp/lzswf9/lzgen7478/LzEvent.as:89]
> 	at LzIdleKernel$/__update()[/private/tmp/lzswf9/lzgen7478/ 
> LzIdleKernel.as:18]

With that small change the fix can be approved.

- Raju


On Jun 3, 2009, at 4:40 AM, Raju Bitter wrote:

> Sorry for the delay, Sarah. Looks good. Approved.
>
> Cheers,
> Raju
>
> On May 31, 2009, at 6:36 PM, Sarah Allen wrote:
>
>> Raju,
>>
>> Can you take a quick look at this fix?  It is a simple logic error  
>> that as been in the code for years.  I ran into, wrote a test file  
>> and fixed it.  Max is not usually up this early and thought you  
>> might be checking email in the evening in your time.
>>
>> Thanks in advance,
>> Sarah
>>
>> Change 20090531-sallen-T by sallen at sallen-mac.local on 2009-05-31  
>> 09:31:16 PDT
>>   in /Users/sarah/src/svn/openlaszlo/trunk-bugfix
>>   for http://svn.openlaszlo.org/openlaszlo/trunk
>>
>> Summary: LPP-8237 When an rtmpconnection is named, it is never used  
>> as the default connection
>>
>> New Features: n/a
>>
>> Bugs Fixed:
>> LPP-8237 When an rtmpconnection is named, it is never used as the  
>> default connection
>>
>> Technical Reviewer: (pending)
>> QA Reviewer: (pending)
>> Doc Reviewer: (pending)
>>
>> Documentation: now the behavior matches the docs
>>
>> Release Notes:
>>
>> Details:
>>
>>
>> Tests:
>> Test file checked in: trunk/test/video/test-rtmp-default.lzx
>> Expected: click the button, status light should turn green
>> Before the fix: the following warnings are reported in the debugger  
>> on app startup
>> WARNING @av/rtmpstatus.lzx#33: reference to undefined property  
>> '_default'
>> WARNING @test-rtmp-default.lzx#18: rtmpconnection not found for / 
>> view[2]/rtmpstatus
>> When you click the button, it stays red, even though the status  
>> text says "connected"
>> Description
>>   As documented, the a/v extensions and components use the first  
>> rtmpconnection that is created if there is none specified for the  
>> component; however, if a rtmpconnection has a name, it is never  
>> used as the default Test file checked in: trunk/test/video/test- 
>> rtmp-default.lzx Expected: click the button, status light should  
>> turn green Results: the following warnings are reported in the  
>> debugger on app startup WARNING @av/rtmpstatus.lzx#33: reference to  
>> undefined property '_default' WARNING @test-rtmp-default.lzx#18:  
>> rtmpconnection not found for /view[2]/rtmpstatus When you click the  
>> button, it stays red, even though the status text says "connected"
>>
>> Files:
>> M      lps/components/extensions/av/rtmpconnection.lzx
>>
>> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20090531-sallen-T.tar
>>
>>
>> http://www.ultrasaurus.com
>>
>>
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.openlaszlo.org/pipermail/laszlo-dev/attachments/20090602/02921020/attachment.html