[Laszlo-dev] For Review: Change 20090602-bargull-GPN Summary: DHTML: add "updateControlKeys" to LzKeyboardKernel

[Max Carlson]

Approved!  See my other email about metaKey.

André Bargull wrote:
> These are just the changes for LzKeyboardKernel. We still need to decide 
> whether "updateControlKeys()" needs to handle the 'metaKey' for LPP-8210.
> 
> 
> Change 20090602-bargull-GPN by bargull at dell--p4--2-53 on 2009-06-02 
> 15:54:52
> in /home/Admin/src/svn/openlaszlo/trunk
> for http://svn.openlaszlo.org/openlaszlo/trunk
> 
> Summary: DHTML: add "updateControlKeys" to LzKeyboardKernel
> 
> New Features:
> 
> Bugs Fixed: LPP-8218 - DHTML: issues with contextmenu onmenuopen, 
> dragging (partial)
> 
> Technical Reviewer: max, ptw
> QA Reviewer: hqm
> Doc Reviewer: (pending)
> 
> Documentation:
> 
> Release Notes:
> 
> Details:
> Call "updateControlKeys()" instead of "__keyboardEvent()" for mouse-events.
> Set "cancelBubble" and "returnValue" after invoking 
> "updateControlKeys()" to mimic old behaviour (this is actually wrong, 
> see LPP-8200, but reduces testing effort right now). "keyCode" is set to 
> 0 for mouse-events in IE, Opera, Safari, so you only need to test for 
> keyCode==0 (Firefox is irrelevant in this case, because it sets keyCode 
> to `undefined` for mouse-events).
> 
> 
> 
> Tests:
> test/lfc/legals/keyboardandmouse.lzx?lzr=dhtml still works as expected
> 
> 
> Files:
> M WEB-INF/lps/lfc/kernel/dhtml/LzKeyboardKernel.js
> M WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
> M WEB-INF/lps/lfc/kernel/dhtml/LzMouseKernel.js
> 
> Changeset: 
> http://svn.openlaszlo.org/openlaszlo/patches/20090602-bargull-GPN.tar
> 

-- 
Regards,
Max Carlson
OpenLaszlo.org