[Laszlo-dev] For Review: Change 20090119-maxcarlson-U Summary: UPDATED AGAIN: Update mediadevice for swf9, add swf9 camera and microphone support

[Sarah Allen]

nice work Max.  Everything looks awesome, but there were a few things  
that I didn't understand...

line 179, mediadevice.lzx
why is onActivityHandler and instance method and onStatus a class method
                     dev.addEventListener(ActivityEvent.ACTIVITY,  
this._onActivityHandler);
                     dev.addEventListener(StatusEvent.STATUS,  
lz.mediadevice._onStatusStatic);

in camera.lzx... did Adobe change the name of this method (or rather  
create an attachCamera as well as attachVideo) in as3?
                     if ($as3) {
                         vid.attachCamera(null);
                     } else {
                         vid.attachVideo(null);
                     }

in microphone.lzx, line 203: why the ignore argument?
         <method name="_updateLevel" args="ignore = null"><![CDATA[

On Jan 20, 2009, at 4:48 AM, Max Carlson wrote:

> Change 20090119-maxcarlson-U by maxcarlson at Bank.lan on 2009-01-19  
> 18:50:33 PST
>    in /Users/maxcarlson/openlaszlo/trunk-clean
>    for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: UPDATED AGAIN: Update mediadevice for swf9, add swf9 camera  
> and microphone support
>
> Bugs Fixed: LPP-7649 - videoview is not participating in  
> simplelayout in swf9, LPP-7572 - updateAllAllowed seems to have  
> gotten lost (I think it was defined in media device), LPP-6984 -  
> swf9: add support for camera and microphone av components
>
> Technical Reviewer: sallen
> QA Reviewer: hminsky
>
> Details: Note that I had to use the debug player to catch the  
> runtime exceptions that were causing these to fail!
>
> test-camera.lzx - Add code to check for invalid camera list before  
> dereferencing it...
>
> microphone.lzx - Add include for $as3.  Add as3 implementation of  
> _makeDevice() that uses the soundTransform property and turns on  
> echo suppression to prevent feedback.  startDevice() as3-specific  
> block stores the microphone's SoundTransform in the _sound  
> property.  Add as3 implementation for _setCapturing().  Add ignore  
> arg for _updateLevel() to make it callable by delegates.
>
> camera.lzx - Update class to use static properties on lz.mediadevice  
> instead of prototypes.  Change _updateAllAllowed() ->  
> _updateAllAllowedStatic() after some archeology revealed this method  
> never existed - at least as far back as r1880 of trunk.  Add as3  
> implementation of _makeDevice(), _setShow(), and getCameraNames().
>
> mediastream.lzx - Refer to canvas.rtmpconnections instead of using  
> prototype.
>
> mediadevice.lzx - Update class to use static properties and methods  
> instead of prototypes.  Add include for $as3.  Use hash of target  
> names to track targets, rather than storing them on the device.  Add  
> as3 implementations of onStatus and onActivity event handlers, use  
> shared code for as3 and as3.  Use allocation="class" for static  
> methods and attributes to eliminate script block.
>
> Tests: See LPP-7649.  test/video/test-microphone.lzx?debug=true runs  
> consistently across swf8 and swf9/10.
>
> Files:
> M      test/video/test-camera.lzx
> M      lps/components/extensions/av/microphone.lzx
> M      lps/components/extensions/av/camera.lzx
> M      lps/components/extensions/av/mediastream.lzx
> M      lps/components/extensions/av/mediadevice.lzx
>
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20090119-maxcarlson-U.tar