[Laszlo-dev] For Review: Change 20090119-sarah-d Summary: changed mediastream.lzx to use regular LZX syntax

Sarah Allen sarah at ultrasaurus.com
Mon Jan 19 19:41:37 PST 2009


_nullnc looks like it it initialized in the type setter
I don't see that uid is used anywhere in the file...

For now I'll leave those both commented out as I try to get the rest  
of the test cases working.  Thanks for pointing them out, though,  
since they may re-appear as we get recording and broadcasting working  
again.

Thanks!
Sarah

On Jan 19, 2009, at 7:22 PM, Max Carlson wrote:

> We need to tie a bug number to this, and also make sure folks know  
> that the tests (example-rtmpconnection.lzx, ...) come from the  
> inline examples for those tags.1
>
> Also, there are e static variables (uid, _nullnc) that were declared  
> before - you might want to do that, but the all 3 testcases worked  
> well for me in swf8 and swf9.
>
> Otherwise, approved!
>
> Sarah Allen wrote:
>> Hey Max -- In theory, nothing has changed except the syntax :)
>> Change 20090119-sarah-d by sarah at sallen-mac.local on 2009-01-19  
>> 19:01:38 PST
>>    in /Users/sarah/src/svn/openlaszlo/tmp/av
>>    for http://svn.openlaszlo.org/openlaszlo/trunk/lps/components/extensions/av
>> Summary: changed mediastream.lzx to use regular LZX syntax
>> New Features: n/a
>> Bugs Fixed: none
>> Technical Reviewer: (pending)
>> QA Reviewer: (pending)
>> Doc Reviewer: (pending)
>> Tests:
>> example-mediastream.lzx
>> swf8 works, swf9 works
>> example-rtmpconnection.lzx
>> swf8 works, swf9 works
>> example-videoview.lzx
>> swf8 works, swf9 works
>> Files:
>> M      lps/components/extensions/av/mediastream.lzx
>> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20090119-sarah-d.tar
>
> -- 
> Regards,
> Max Carlson
> OpenLaszlo.org



More information about the Laszlo-dev mailing list