[Laszlo-dev] code review for replicator.lzx

Lee Lundrigan llundrigan at laszlosystems.com
Thu Jan 15 10:23:35 PST 2009


I posted it to the bug. Hope it helps!

P T Withington wrote:
> Can you set Debug.showInternalProperties to true and get another bug 
> report?
>
> After provoke the error, enter:
>
>   Debug.showInternalProperties=true
>
> in the debug evaluator, then once again inpsect the error and invoke 
> Debug.bugReport.  This will give us a little more information that 
> should help track the real error down.
>
> Thanks!
>
> On 2009-01-15, at 12:52EST, Lee Lundrigan wrote:
>
>> Okay, I ran a bug report and posted it to LPP-7633.
>>
>> Let me know what you find.
>>
>> Thanks guys! :)
>> Lee
>>
>> P T Withington wrote:
>>> André has annotate the bug you filed explaining the problem.  There 
>>> is clearly a deeper issue because if p really is an Array, it will 
>>> have a length...
>>>
>>> If you can get a Debug.bugReport in the Jira, we can try to track 
>>> down the real issue.
>>>
>>> On 2009-01-14, at 20:13EST, Lee Lundrigan wrote:
>>>
>>>> The debugger window in Webtop was reporting a warning that the 'p' 
>>>> did not have a 'length' attribute on it and 'p' is an array of 
>>>> data. By adding the p['length'] solved the problem with the 
>>>> warnings. I am doing something wrong?
>>>>
>>>> Thanks,
>>>> Lee
>>>>
>>>> P T Withington wrote:
>>>>> This doesn't seem right to me.  What is the bug you are trying to 
>>>>> fix?  Please file a Jira bug with a test case first.
>>>>>
>>>>> On 2009-01-14, at 19:56EST, Lee Lundrigan wrote:
>>>>>
>>>>>> Change 20090114-Lee-Z by Lee at Jaz-2.local on 2009-01-14 16:47:18 PST
>>>>>> in /Users/Lee/src/svn/openlaszlo/trunk/lps
>>>>>> for http://svn.openlaszlo.org/openlaszlo/trunk/lps
>>>>>>
>>>>>> Summary:
>>>>>> There were places in the replicator.lzx that were calling p.length
>>>>>> I changed these references to p['length']
>>>>>>
>>>>>> New Features:
>>>>>>
>>>>>> Bugs Fixed:
>>>>>>
>>>>>> Technical Reviewer: (pending)
>>>>>> QA Reviewer: (pending)
>>>>>> Doc Reviewer: (pending)
>>>>>>
>>>>>> Documentation:
>>>>>>
>>>>>> Release Notes:
>>>>>>
>>>>>> Details:
>>>>>>
>>>>>> Tests:
>>>>>>
>>>>>> Files:
>>>>>> M      components/utils/replicator/replicator.lzx
>>>>>>
>>>>>> Changeset: 
>>>>>> http://svn.openlaszlo.org/openlaszlo/patches/20090114-Lee-Z.tar
>>>>>
>>>>
>>>
>>
>




More information about the Laszlo-dev mailing list