[Laszlo-dev] code review for replicator.lzx

[P T Withington]

Verily.

Perhaps [this](http://wiki.openlaszlo.org/Code_Review_Process) needs  
to be updated and made more visible?

On 2009-01-14, at 20:39EST, Lou Iorio wrote:

> Point of parliamentary procedure:
>
> You (or someone else) should file a JIRA bug with the problem first.  
> That's the
> way we track changes.
>
> Then, when you make a change, you should reference that bug number,  
> assign
> a reviewer, and indicate how you tested the fix.
>
> On Jan 14, 2009, at 9:13 PM, Lee Lundrigan wrote:
>
>> The debugger window in Webtop was reporting a warning that the 'p'  
>> did not have a 'length' attribute on it and 'p' is an array of  
>> data. By adding the p['length'] solved the problem with the  
>> warnings. I am doing something wrong?
>>
>> Thanks,
>> Lee
>>
>> P T Withington wrote:
>>> This doesn't seem right to me.  What is the bug you are trying to  
>>> fix?  Please file a Jira bug with a test case first.
>>>
>>> On 2009-01-14, at 19:56EST, Lee Lundrigan wrote:
>>>
>>>> Change 20090114-Lee-Z by Lee at Jaz-2.local on 2009-01-14 16:47:18 PST
>>>> in /Users/Lee/src/svn/openlaszlo/trunk/lps
>>>> for http://svn.openlaszlo.org/openlaszlo/trunk/lps
>>>>
>>>> Summary:
>>>> There were places in the replicator.lzx that were calling p.length
>>>> I changed these references to p['length']
>>>>
>>>> New Features:
>>>>
>>>> Bugs Fixed:
>>>>
>>>> Technical Reviewer: (pending)
>>>> QA Reviewer: (pending)
>>>> Doc Reviewer: (pending)
>>>>
>>>> Documentation:
>>>>
>>>> Release Notes:
>>>>
>>>> Details:
>>>>
>>>> Tests:
>>>>
>>>> Files:
>>>> M      components/utils/replicator/replicator.lzx
>>>>
>>>> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20090114-Lee-Z.tar
>>>
>>
>