[Laszlo-dev] [Laszlo-builds] FAILURE for 12421-openlaszlo-branches-4.2 on linux-builder.corp.laszlosystems.com

[Amy Muntz]

I've re-opened http://www.openlaszlo.org/jira/browse/LPP-7514
so that we can track these changes. Please update accordingly
with the latest change.

Thanks!
--- Amy


On Mon, Jan 12, 2009 at 10:59 AM , P T Withington wrote:

> Trying again with this change:
>
> Index: CommonGenerator.java
> ===================================================================
> --- CommonGenerator.java	(revision 12423)
> +++ CommonGenerator.java	(working copy)
> @@ -1071,6 +1071,9 @@
>    boolean isExpressionType(SimpleNode node) {
>      // There are several AST types that end with each of the names 
> that
>      // endsWith tests for.
> +    if (node instanceof ASTModifiedDefinition) {
> +      node = node.get(0);
> +    }
>      String name = node.getClass().getName();
>      return name.endsWith("Expression") ||
>        name.endsWith("FunctionCallParameters") ||
>
> On 2009-01-12, at 10:54EST, P T Withington wrote:
>
>> I believe this is because the build servers (and I) both run with 
>> assertions enabled:
>>
>> JAVA_OPTS=-ea -Xmx384m
>>
>> And there is an assertion:
>>
>>>  /* This function, unlike the other expression visitors, can be
>>>     applied to any expression node, so it dispatches based on the
>>>     node's class. */
>>>  public SimpleNode visitExpression(SimpleNode node, boolean 
>>> isReferenced) {
>>>    assert isExpressionType(node) : "" + node + ": " + (new 
>>> ParseTreePrinter()).text(node) + " is not an expression";
>>
>> I guess you have added ModfiedDefinition, but didn't tell 
>> isExpression about it?
>>
>> On 2009-01-12, at 10:49EST, P T Withington wrote:
>>
>>> Houston, we have a problem.  Don, I get this same error if I try to 
>>> build locally on trunk...
>>>
>>> lzl:
>>>    [echo] Compiling /home/svnbuild/builds/12421-openlaszlo- 
>>> branches-4.2/lps/includes/lfc/LFCdhtml.js
>>>    [java] Exception in thread "main" java.lang.AssertionError: 
>>> ModifiedDefinition(): function $lzsc$initialize (message = null) {
>>>    [java] if (message != null) {
>>>    [java] this.appendInternal("" + message, message)
>>>    [java] }} is not an expression
>>>    [java] 	at  org .openlaszlo 
>>> .sc.JavascriptGenerator.visitExpression(JavascriptGenerator.java:675)
>>>    [java] 	at  org .openlaszlo 
>>> .sc.JavascriptGenerator.visitArrayLiteral(JavascriptGenerator.java: 
>>> 748)
>>>    [java] 	at  org .openlaszlo 
>>> .sc.CommonGenerator.dispatchExpression(CommonGenerator.java:1105)
>>>    [java] 	at  org .openlaszlo 
>>> .sc.JavascriptGenerator.visitExpression(JavascriptGenerator.java:681)
>>>    [java] 	at  org .openlaszlo 
>>> .sc.JavascriptGenerator.visitExpression(JavascriptGenerator.java:668)
>>>    [java] 	at  org .openlaszlo .sc .JavascriptGenerator 
>>> .translateFunctionCallParameters(JavascriptGenerator.java:796)
>>>    [java] 	at  org .openlaszlo .sc 
>>> .JavascriptGenerator.visitCallExpression(JavascriptGenerator.java: 
>>> 928)
>>>    [java] 	at  org .openlaszlo 
>>> .sc.CommonGenerator.dispatchExpression(CommonGenerator.java:1123)
>>>    [java] 	at  org .openlaszlo 
>>> .sc.JavascriptGenerator.visitExpression(JavascriptGenerator.java:681)
>>>    [java] 	at  org 
>>> .openlaszlo.sc.CommonGenerator.visitStatement(CommonGenerator.java: 
>>> 857)
>>>    [java] 	at  org 
>>> .openlaszlo.sc.CommonGenerator.visitStatement(CommonGenerator.java: 
>>> 751)
>>>    [java] 	at  org .openlaszlo 
>>> .sc.CommonGenerator.visitStatementList(CommonGenerator.java:881)
>>>    [java] 	at  org 
>>> .openlaszlo.sc.CommonGenerator.visitStatement(CommonGenerator.java: 
>>> 777)
>>>    [java] 	at  org 
>>> .openlaszlo.sc.CommonGenerator.visitStatement(CommonGenerator.java: 
>>> 751)
>>>    [java] 	at  org .openlaszlo 
>>> .sc.CommonGenerator.visitClassDefinition(CommonGenerator.java:447)
>>>    [java] 	at  org 
>>> .openlaszlo.sc.CommonGenerator.visitStatement(CommonGenerator.java: 
>>> 774)
>>>    [java] 	at  org 
>>> .openlaszlo.sc.CommonGenerator.visitStatement(CommonGenerator.java: 
>>> 751)
>>>    [java] 	at  org .openlaszlo 
>>> .sc.CommonGenerator.visitModifiedDefinition(CommonGenerator.java:915)
>>>    [java] 	at  org .openlaszlo 
>>> .sc.JavascriptGenerator.visitProgram(JavascriptGenerator.java:294)
>>>    [java] 	at  org .openlaszlo 
>>> .sc.JavascriptGenerator.translateInternal(JavascriptGenerator.java: 
>>> 170)
>>>    [java] 	at  org .openlaszlo 
>>> .sc.JavascriptGenerator.translateInclude(JavascriptGenerator.java: 
>>> 347)
>>>    [java] 	at  org .openlaszlo 
>>> .sc.JavascriptGenerator.visitProgram(JavascriptGenerator.java:278)
>>>    [java] 	at  org .openlaszlo 
>>> .sc.JavascriptGenerator.translateInternal(JavascriptGenerator.java: 
>>> 170)
>>>    [java] 	at  org .openlaszlo 
>>> .sc.JavascriptGenerator.translateInclude(JavascriptGenerator.java: 
>>> 347)
>>>    [java] 	at  org .openlaszlo 
>>> .sc.JavascriptGenerator.visitProgram(JavascriptGenerator.java:278)
>>>    [java] 	at  org .openlaszlo 
>>> .sc.JavascriptGenerator.visitProgram(JavascriptGenerator.java:208)
>>>    [java] 	at  org .openlaszlo 
>>> .sc.JavascriptGenerator.translateInternal(JavascriptGenerator.java: 
>>> 170)
>>>    [java] 	at  org .openlaszlo 
>>> .sc.JavascriptGenerator.translate(JavascriptGenerator.java:44)
>>>    [java] 	at org.openlaszlo.sc.Compiler.compile(Compiler.java:358)
>>>    [java] 	at org.openlaszlo.sc.lzsc.compile(lzsc.java:110)
>>>    [java] 	at org.openlaszlo.sc.lzsc.compile(lzsc.java:325)
>>>    [java] 	at org.openlaszlo.sc.Main.main(Main.java:10)
>>>
>>>
>>