[Laszlo-dev] For Review: Change 20090107-hqm-K Summary: update conversion script and test case for deprecated urlEscape method

Henry Minsky hminsky at laszlosystems.com
Wed Jan 7 14:16:45 PST 2009


BTW, I am assuming that the convert_required.pl got run first, so
calls to LzBrowser have been
converted to lz.Browser already



On Wed, Jan 7, 2009 at 5:11 PM, P T Withington <ptw at laszlosystems.com> wrote:
> This comment:
>
> +$xform{urlescape}=1;    # transform lz.embed.urlEscape/urlUnescape() ->
> encodeURIComponent,decodeURIComponent
>
> looks wrong s/embed/Browser/
>
> If you assert that you grepped all the examples/demos/components for
> urlEscape and urlUnescape and these are the only two places the deprecated
> forms are used, then approved.
>
> On 2009-01-07, at 17:04EST, Henry Minsky wrote:
>
>> Change 20090107-hqm-K by hqm at badtzmaru.home on 2009-01-07 17:03:24 EST
>>   in /Users/hqm/openlaszlo/trunk3
>>   for http://svn.openlaszlo.org/openlaszlo/trunk
>>
>> Summary:  update conversion script and test case for deprecated urlEscape
>> method
>>
>> New Features:
>>
>> Bugs Fixed: LPP-7582
>>
>> Technical Reviewer: ptw
>> QA Reviewer: (pending)
>> Doc Reviewer: (pending)
>>
>> Documentation:
>>
>> Release Notes:
>>
>> Details:
>>
>> + replace lz.Browser.urlEscape with encodeURIComponent
>>
>> + add transform to conversion script to do this
>>
>> Tests:
>>
>> smokecheck
>>
>> Files:
>> M      test/smoke/regression.lzl
>> M      test/lfc/perf/reporter.lzx
>> M      WEB-INF/lps/server/bin/convert_laszlo.pl
>>
>>
>> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20090107-hqm-K.tar
>
>



-- 
Henry Minsky
Software Architect
hminsky at laszlosystems.com


More information about the Laszlo-dev mailing list