[Laszlo-dev] [Laszlo-checkins] r12323 - openlaszlo/trunk/WEB-INF/lps/lfc/views

[P T Withington]

If this is our policy, to always send an event when setting, even if  
to the same value, then the x/y/width/height memoization I just fixed  
need the same treatment.  (I'll do that now.)

Since the purpose of the memoization (AFAICT) is to avoid redundant  
calls as constraint settle during initialization, it might be worth  
our while to also check that the event is not locked before sending  
(if it is locked, it means we are already recursing in the event  
system, so the call would be a no-op).

On 2009-01-07, at 03:27EST, max at openlaszlo.org wrote:

> Author: max
> Date: 2009-01-07 00:27:28 -0800 (Wed, 07 Jan 2009)
> New Revision: 12323
>
> Modified:
>   openlaszlo/trunk/WEB-INF/lps/lfc/views/LzText.lzs
> Log:
> Change 20090106-maxcarlson-C by maxcarlson at Bank.lan on 2009-01-06  
> 21:22:05 PST
>    in /Users/maxcarlson/openlaszlo/trunk-clean
>    for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: Always send ontext when text attribute is set
>
> Bugs Fixed: LPP-7109 - Ontext events don't seem to fire if the text  
> is set to the same value, LPP-7567 - if the text of inputtext is "",  
> and when setAttribute text to "" , the ontext event will not be sent
>
> Technical Reviewer: andre.bargull at udo.edu
> QA Reviewer: promanik
>
> Details: Always send ontext, even when the value didn't change.
>
> Tests: See LPP-7109 and LPP-7567
>
>
>
> Modified: openlaszlo/trunk/WEB-INF/lps/lfc/views/LzText.lzs
> ===================================================================
> --- openlaszlo/trunk/WEB-INF/lps/lfc/views/LzText.lzs	2009-01-07  
> 08:27:03 UTC (rev 12322)
> +++ openlaszlo/trunk/WEB-INF/lps/lfc/views/LzText.lzs	2009-01-07  
> 08:27:28 UTC (rev 12323)
> @@ -1,6 +1,6 @@
> /**
>   *
> -  * @copyright Copyright 2001-2008 Laszlo Systems, Inc.  All Rights  
> Reserved.
> +  * @copyright Copyright 2001-2009 Laszlo Systems, Inc.  All Rights  
> Reserved.
>   *            Use is subject to license terms.
>   *
>   * @access public
> @@ -398,7 +398,10 @@
>     // force to a string
>     t = String(t);
>
> -    if (this._textrecompute != true && t == this.getText()) return;
> +    if (this._textrecompute != true && t == this.getText()) {
> +        if (this.ontext.ready) this.ontext.sendEvent(t);
> +        return;
> +    }
>     var tsprite:LzTextSprite = (this.sprite cast LzTextSprite);
>     if (this.visible) tsprite.setVisible(this.visible);
>     if (this.maxlength != null && t.length > this.maxlength){
>
>
> _______________________________________________
> Laszlo-checkins mailing list
> Laszlo-checkins at openlaszlo.org
> http://www.openlaszlo.org/mailman/listinfo/laszlo-checkins