[Laszlo-dev] [Laszlo-checkins] r12330 - openlaszlo/trunk/lps/components/extensions/av

[P T Withington]

Since that code is only used for debugging, you ought to put it in an  
`if ($debug)`, so it gets compiled out when not.

Note if you need to have a debug-only method in LZX, <switch> has new  
options for <when> and <unless>:

<switch>
   <when condition="$debug">
     ... Will only compile if $debug flag is on ...
   <when>
</switch>

[Henry will correct me if I didn't get the syntax exactly right...]

On 2009-01-07, at 06:17EST, sallen at openlaszlo.org wrote:

> Author: sallen
> Date: 2009-01-07 03:17:52 -0800 (Wed, 07 Jan 2009)
> New Revision: 12330
>
> Modified:
>   openlaszlo/trunk/lps/components/extensions/av/rtmpconnection.lzx
> Log:
> Change 20090107-sarah-H by sarah at sarah-allens-macbook-pro.local on  
> 2009-01-07 03:00:21 PST
>    in /Users/sarah/src/svn/openlaszlo/trunk/lps/components/ 
> extensions/av
>    for http://svn.openlaszlo.org/openlaszlo/trunk/lps/components/extensions/av
>
> Summary: fixed warning, added credit to other contributors (but not  
> core team, is that right?)
>
> Bugs Fixed:
>    LPP-7543  debugger warning in rtmpconnection when running doc  
> example
>
> Technical Reviewer: Max
> QA Reviewer: (pending)
> Doc Reviewer: n/a
>
> Documentation: n/a
>
> Release Notes: n/a
>
> Details: just needed to check for undefined
>
>
> Tests:
> http://localhost:8080/trunk/test/video/test-rtmpconnection.lzx?debug=true
> tested with Red5 for case of connection success and connection failure
>
>
>
> Modified: openlaszlo/trunk/lps/components/extensions/av/ 
> rtmpconnection.lzx
> ===================================================================
> --- openlaszlo/trunk/lps/components/extensions/av/rtmpconnection.lzx	 
> 2009-01-07 11:07:50 UTC (rev 12329)
> +++ openlaszlo/trunk/lps/components/extensions/av/rtmpconnection.lzx	 
> 2009-01-07 11:17:52 UTC (rev 12330)
> @@ -1,10 +1,12 @@
> <!-- * X_LZ_COPYRIGHT_BEGIN  
> ***************************************************
> -* Copyright 2006-2008 Laszlo Systems, Inc.  All Rights  
> Reserved.              *
> +* Copyright 2006-2009 Laszlo Systems, Inc.  All Rights  
> Reserved.              *
> * Use is subject to license  
> terms.                                            *
> * X_LZ_COPYRIGHT_END  
> ****************************************************** -->
> <library>
>   <!--
> -      Based on code by Raju Bitter
> +      Originally written by Sarah Allen
> +      Improvements by Sebastian Wagner
> +      Support for OL 4.2/SWF9 by Raju Bitter
>   -->
>   <interface name="rtmpconnection" extends="node">
>     <doc>
> @@ -238,11 +240,12 @@
>             function _onStatus (evt) {
>                 if ($as3) evt = evt.info;
>                 var code = evt.code;
> -                var description = evt.description;
> +
> +                // only used for debugging
> +                var description = evt['description'] ?  
> evt.description : "";
>
>                 //Debug.write(evt);
> -                //Debug.write("rtmpconnection", this, "_onStatus",  
> code);
> -                //Debug.write("Net status description: ",  
> description);
> +                //Debug.write("rtmpconnection", this, "_onStatus",  
> code, description);
>
>                 if (this.debug) {
>                     if ($debug) Debug.write("rtmpconnection", this,  
> "_onStatus", code);
>
>
> _______________________________________________
> Laszlo-checkins mailing list
> Laszlo-checkins at openlaszlo.org
> http://www.openlaszlo.org/mailman/listinfo/laszlo-checkins