[Laszlo-dev] For Review: Change 20090106-ptw-x Summary: Fix view position and dimension memoization

[André Bargull]

Approved, if you change:
> +    if (args['width'] || this.__LZhasConstraint('width')) {
to:
> +    if (args['width'] != null || this.__LZhasConstraint('width')) {

in case of a zero width. Same for the height check.


On 1/6/2009 11:11 PM, P T Withington wrote:
> Change 20090106-ptw-x by ptw at dueling-banjos.home on 2009-01-06 
> 16:01:34 EST
>     in /Users/ptw/OpenLaszlo/trunk
>     for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: Fix view position and dimension memoization
>
> Bugs Fixed:
> LPP-7560  null value of an attribute should not be 0
>
> Technical Reviewer: a.bargull at intensis.de (pending)
> QA Reviewer: fguo at laszlosystems.com (pending)
>
> Details:
>     Renamed the memoization fields to be more explicit.  Made the
>     memoization comparison use identity not equality.  Removed the
>     redundant recompute flags (replaced by just clearing
>     memoization).  Corrected constructor test for explicit
>     height/width.  Added extensive comments so this code won't seem so
>     magical to the next viewer.  Moved kernel calls for width/height
>     so unnecessary calls are not made (kernels should never see a null
>     value now...)
>
> Tests:
>     smokecheck, test case from bug
>
> Files:
> M      WEB-INF/lps/lfc/views/LaszloView.lzs
>
> Changeset: 
> http://svn.openlaszlo.org/openlaszlo/patches/20090106-ptw-x.tar
>