[Laszlo-dev] UPDATED For Review: Change 20090105-hqm-R Summary: fix url encoding problem

[Henry Minsky]

Yes, I will do that.



On Tue, Jan 6, 2009 at 4:25 PM, P T Withington <ptw at laszlosystems.com> wrote:
> On 2009-01-06, at 16:15EST, Henry Minsky wrote:
>
>>>
>>> For swf9, I can't tell if there is a bug in the platform implementation
>>> or
>>> not.  It sounds like the problem was simply that we weren't calling the
>>> correct platform function (we were calling escape, as we did in swf8,
>>> when
>>> we should have been calling encodeURI).
>>>
>>
>> Yeah, I  first  thought they were saying they saw a bug in swf9 's
>> encodeURIComponent, but
>> it looks like they were getting the output of the swf9 'escape'
>> function and that was garbling their unicode strings.
>
> Then the minimal fix, which should go into 4.2.0.1 is simply to make
> `lz.Browser.urlEscape` call `encodeURIComponent` on all platforms (and leave
> the as2 alias for `encodeURIComponent` in LzRuntime pointing at `escape`).
>
> And, while you are in there, you could deprecate urlEscape and tell people
> to use encodeURIComponent.  No sense duplicating a perfectly good standard.
>
>
>



-- 
Henry Minsky
Software Architect
hminsky at laszlosystems.com