[Laszlo-dev] UPDATED For Review: Change 20081231-hqm-K Summary: fix null pointer error in <switch> statement

[André Bargull]

Not approved.

1. There is some debug code in Parser.java
> +            System.err.println("getCompileTimeConstants = "+cc);


2. And the "debug" and "profile" attributes on <canvas> can override the 
default runtime properties (see l. 436-444 in Compiler.java). So with 
your change the following testcase is no longer compiled in (proper) 
debug-mode.
In swf8, the debug-window doesn't show up, although `$debug` evaluates 
to `true`. In dhtml, the debug console shows up and the debug-lfc is 
included, but `$debug` evals to `false`. And swf9 doesn't compile at 
all, compile-error was:
> Access to an undefined property LzDebuggerWindowConsoleBridge.



testcase:
---
<canvas debug="true" >
   <handler name="oninit" >
     txt.addFormat("$debug = %w", $debug === true);
   </handler>
   <text id="txt" />
</canvas>
---

On 1/1/2009 5:08 AM, Henry Minsky wrote:
> Sorry, had bogus modified file in previous tar file...
> 
> 
> 
> Change 20081231-hqm-K by hqm at badtzmaru.home on 2008-12-31 12:05:35 EST
>     in /Users/hqm/openlaszlo/trunk4
>     for http://svn.openlaszlo.org/openlaszlo/trunk
> 
> Summary: fix null pointer error in <switch> statement
> 
> New Features:
> 
> Bugs Fixed: LP-6982
> 
> Technical Reviewer: andre
> QA Reviewer: promanik
> Doc Reviewer: (pending)
> 
> Documentation:
> 
> Release Notes:
> 
> <switch> statement now supports an <unless> clause
> 
> example:
> 
> <switch>
>   <unless property="$dhtml">
>      [lzx code to be included]
>   </unless>
> </switch>
> 
> 
> Details:
> 
> + initialize compile time constants table before running the parser
> 
> + added <unless> clause
> 
> Tests:
> 
> test case from bug report
> 
> Files:
> M      WEB-INF/lps/server/src/org/openlaszlo/compiler/Parser.java
> M      WEB-INF/lps/server/src/org/openlaszlo/compiler/Compiler.java
> 
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20081231-hqm-K.tar
>